Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display seed phrase reminder if user has tokens #6952

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 2, 2019

The seed phrase reminder will now be triggered if the user has eth OR if the user has added a token. This is to ensure that a user can't have a positive token balance without being reminded to backup the account.

Checking for the token in preferences was easier than checking the actual token balance, because the token balance is not yet in Redux. That would require a more substantial refactor.

The seed phrase reminder will now be triggered if the user has eth *OR*
if the user has added a token. This is to ensure that a user can't have
a positive token balance without being reminded to backup the account.

Checking for the token in preferences was easier than checking the
actual token balance, because the token balance is not yet in Redux.
That would require a more substantial refactor.
@Gudahtt Gudahtt requested review from danjm and whymarrh as code owners August 2, 2019 16:41
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@Gudahtt Gudahtt merged commit 2649b9b into MetaMask:develop Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants