Address book name save fix #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
force-pushed
the
address-book-name-save-fix
branch
from
3de78eb to
2fe540a
Compare
Gudahtt
reviewed
Aug 2, 2019
| @@ -51,6 +50,7 @@ concurrently --kill-others \ | |||
| 'npm run sendwithprivatedapp' \ | |||
| 'sleep 5 && mocha test/e2e/incremental-security.spec' | |||
|
|
|||
| export GANACHE_ARGS="$GANACHE_ARGS --deterministic --account=0x53CB0AB5226EEBF4D872113D98332C1555DC304443BEE1CF759D15798D3C55A9,25000000000000000000" | |||
There was a problem hiding this comment.
The $GANACHE_ARGS here includes all of the previous exported values (e.g. it'll have each of the --account flags listed one after another, along with the 3 instances of the --deterministic flag).
I'm guessing this isn't what we want. This was broken already, but I'm mentioning in case it relates to the test failure.
There was a problem hiding this comment.
This could most easily be fixed by renaming the first case as BASE_GANACHE_ARGS or something like that.
There was a problem hiding this comment.
Yeah, that could be another PR
There was a problem hiding this comment.
This has been addressed in #6970
Gudahtt
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issues with saving contacts.
Adds e2e tests to cover the following flow: