Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Babel 7 #6942

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Upgrade to Babel 7 #6942

merged 1 commit into from
Aug 2, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 1, 2019

Babel 7 moved to a new configuration format, and they've scoped all of their packages under @babel/. This brings MetaMask in-line with dependencies we use that already use Babel 7, and it eliminates a few unfortunate edge cases that can prevent dependencies from being correctly transpiled.

whymarrh
whymarrh previously approved these changes Aug 2, 2019
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change to get into v7

whymarrh
whymarrh previously approved these changes Aug 2, 2019
Babel 7 moved to a new configuration format, and they've scoped all of
their packages under `@babel/`. This brings MetaMask in-line with
dependencies we use that _already_ use Babel 7, and it eliminates a
few unfortunate edge cases that can prevent dependencies from being
correctly transpiled.
@Gudahtt Gudahtt merged commit 6a0dbcd into MetaMask:develop Aug 2, 2019
@whymarrh whymarrh mentioned this pull request Aug 8, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants