Contact list

[jennypollack]

No description provided.

[metamaskbot]

Builds ready [a96ad0f]: chrome, firefox, edge, opera

[danjm]

@jennypollack Can you include a description of the PR and some screen shots or screen captures of it being used?

[chikeichan]

@jennypollack here is some styling edits!

[metamaskbot]

Builds ready [43121e1]: chrome, firefox, edge, opera

[jennypollack]

http://g.recordit.co/Wu0ITQuLeK.gif @danjm gif of settings flow
this is dependent on a gaba release with MetaMask/core#132 and requires a version bump in the extension as well

[metamaskbot]

Builds ready [c99bff3]: chrome, firefox, edge, opera

[metamaskbot]

Builds ready [ba554d7]: chrome, firefox, edge, opera

[metamaskbot]

Builds ready [7093b46]: chrome, firefox, edge, opera

[danjm]

Code looks good overall. Most changes I've suggested are related to code patterns or logic simplifications. These are none critical.

The only truly important changes I suggest relate to how we handle and show validation errors in the add-contact and edit-contact components

[danjm]

The approval I just made was supposed to be a "Request Changes" 😆

[danjm]

We should also get some design review in here @bdresser

[bdresser]

noticing some UI issues

• full screen button & inputs
• "Contact List" settings option opens the wrong settings view (every time after first time)

[bdresser]

cc @jennypollack @danjm

[metamaskbot]

Builds ready [623cd77]: chrome, firefox, edge, opera

[metamaskbot]

Builds ready [ee9864f]: chrome, firefox, edge, opera