feature: integrate gaba/CurrencyRateController #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
requested review from
danfinlay,
brunobar79,
whymarrh,
jennypollack and
frankiebee
bitpshr
force-pushed
the
feature/gaba-currency-controller
branch
from
017d780 to
1a808c0
Compare
whymarrh
force-pushed
the
feature/gaba-currency-controller
branch
3 times, most recently
from
39a118e to
164fa1c
Compare
|
Updated to resolve conflicts post-#6569 |
|
This LGTM though we'll need to work out the e2e failures (cc @tmashuang) |
bitpshr
force-pushed
the
feature/gaba-currency-controller
branch
from
164fa1c to
01d75f8
Compare
|
Based on the previous review and approval pending e2e tests passing, figured this was safe to finally land. For posterity, the e2e test failure was because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates
gaba/CurrencyRateControllerand removes the oldCurrencyController.Resolves #6536
Example fiat conversion:
rates:**