Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded array cloning in getSendToAccounts selector #6448

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Remove unneeded array cloning in getSendToAccounts selector #6448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ui/app/components/app/send/send.selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,7 @@ function getSendTo (state) {
function getSendToAccounts (state) {
const fromAccounts = accountsWithSendEtherInfoSelector(state)
const addressBookAccounts = getAddressBook(state)
const allAccounts = [...fromAccounts, ...addressBookAccounts]
// TODO: figure out exactly what the below returns and put a descriptive variable name on it
return Object.entries(allAccounts).map(([key, account]) => account)
return [...fromAccounts, ...addressBookAccounts]
}

function getSendWarnings (state) {
Expand Down