feature: switch token pricing to CoinGecko API #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
requested review from
danfinlay,
brunobar79,
whymarrh,
danjm and
tmashuang
whymarrh
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
TokenRatesControllerto use the CoinGecko API instead of the Balanc3 API that will be shut down in the near future. The API seemed to hold up under the local stress tests I did (50+ tokens per request at 100 requests per minute - the rate limit max - for several minutes).We may want to release this slowly to a small percentage of clients since it's a new API for a feature that's very visible to users.
Resolves #6383