Show popup if notification or activeMMtab is true #6223
Conversation
tmashuang
changed the title
|
I think that the change that was made in #6183 was a mistake. (And my mistake for approving it) I think the logic before that change reflects what we desire: new popup windows should not be opened if there is a metamask tab currently opened, if there is a notification window currently open or if the extension popup is open. What we need to do is address the case when there is a notification window open but not in focus. It needs to be brought into focus. I think it would be good if we revert the change made in #6183 and then find an alternate solution for bringing an out of focus notification window into focus. |
app/scripts/background.js
Outdated
| @@ -448,7 +448,7 @@ function setupController (initState, initLangCode) { | |||
| function triggerUi () { | |||
| extension.tabs.query({ active: true }, tabs => { | |||
| const currentlyActiveMetamaskTab = Boolean(tabs.find(tab => openMetamaskTabsIDs[tab.id])) | |||
| if ((!popupIsOpen || !notificationIsOpen) && !currentlyActiveMetamaskTab) { | |||
| if ((!popupIsOpen || notificationIsOpen) && !currentlyActiveMetamaskTab) { | |||
There was a problem hiding this comment.
I think this will result in multiple notification windows being opened if multiple txs are created before any one is confirmed/rejected.
There was a problem hiding this comment.
That's not the case.
There was a problem hiding this comment.
So maybe notifcationIsOpen can be removed entirely from the if expression?
but not if popup(extension view) is open
Fixes #6221