Fix gas estimation when sending to contracts. #6195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
force-pushed
the
correct-gas-estimation-contracts
branch
2 times, most recently
from
6647aee to
3a966a7
Compare
whymarrh
suggested changes
Feb 25, 2019
ui/app/components/send/send-content/send-gas-row/send-gas-row.container.js
Show resolved
Hide resolved
danjm
force-pushed
the
correct-gas-estimation-contracts
branch
from
3a966a7 to
a08f8f4
Compare
danjm
force-pushed
the
correct-gas-estimation-contracts
branch
from
a08f8f4 to
a599ccd
Compare
whymarrh
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5894
When estimating gas limit for a send to a contract and with a 0 value, the methods we rely on for estimation default to provided gas limits. To get an estimate that is based on the contract itself, the estimation method needs to be passed a non-zero value.