Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the repeated getSelectedAddress() func send.selectors.js is removed #6056

Merged
merged 3 commits into from
Apr 11, 2019
Merged

the repeated getSelectedAddress() func send.selectors.js is removed #6056

merged 3 commits into from
Apr 11, 2019

Conversation

Sneh1999
Copy link
Contributor

  • getSelectedAddress() is removed from send.selectors.js and was imported from selectors.js
  • All other imports were also made from selectors.js

@Sneh1999 Sneh1999 requested a review from danjm January 22, 2019 17:18
@danjm
Copy link
Contributor

danjm commented Jan 22, 2019

Looks good @Sneh1999

Can you run npm run lint:fix locally, make any necessary changes and then push the code again. This should be good to merge then.

@Sneh1999 Sneh1999 force-pushed the getSelectedAddress-removed branch from db2d381 to ea26e77 Compare January 23, 2019 17:54
@danjm
Copy link
Contributor

danjm commented Jan 30, 2019

@Sneh1999 I think the e2e tests might pass if you rebase this onto the latest develop. Let me know if you need any help with that.

@Sneh1999 Sneh1999 force-pushed the getSelectedAddress-removed branch from ea26e77 to 0ce96c4 Compare February 8, 2019 19:44
@metamaskbot
Copy link
Collaborator

Builds ready [0ce96c4]: mascara, chrome, firefox, edge, opera

whymarrh
whymarrh suggested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop the lockfile changes before merging

@whymarrh whymarrh removed the request for review from alextsg March 29, 2019 16:15
@Sneh1999 Sneh1999 force-pushed the getSelectedAddress-removed branch from 0ce96c4 to bb39d44 Compare April 8, 2019 18:13
@metamaskbot
Copy link
Collaborator

Builds ready [441dbf5]: chrome, firefox, edge, opera

@danjm danjm force-pushed the getSelectedAddress-removed branch from 441dbf5 to 8072448 Compare April 10, 2019 13:53
@metamaskbot
Copy link
Collaborator

Builds ready [8072448]: chrome, firefox, edge, opera

@whymarrh whymarrh merged commit 2786932 into develop Apr 11, 2019
@whymarrh whymarrh deleted the getSelectedAddress-removed branch April 11, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sneh1999 @danjm @metamaskbot @whymarrh