Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Bump #5909

Merged
merged 72 commits into from
Dec 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
f9aa5a7
Adds new gas customization modal container (without content)
danjm Jul 31, 2018
88d8eb2
Use correct message key in gas-modal-page-container.component.js
danjm Aug 6, 2018
5e74094
Use BEM for css in gas-modal-page-container
danjm Aug 6, 2018
342dc95
Adds the content of the advanced tab - w/o chart or dynamic content -…
danjm Aug 2, 2018
d55a261
Split advanced-tab-content.component.js render() method into smaller…
danjm Aug 7, 2018
3b9ec8e
Remove gas slider from advance-tab-content.component
danjm Aug 7, 2018
99c8804
Add tests for advanced-tab-component.js and subcomponents.
danjm Aug 8, 2018
57cd721
Improve styling of advanced-tab-content gasInput row
danjm Aug 8, 2018
112d18e
Adds basic tab content to gas customizer, with styled button group (s…
danjm Aug 9, 2018
0a7dfcd
Connect the gas-button-group component to redux and a live api.
danjm Aug 16, 2018
d07d40c
Improvements to propdefaults in button-group.component and basic-tab-…
danjm Sep 9, 2018
58feb24
Styling fixes for gas customization advanced tab content.
danjm Sep 9, 2018
6ada9b4
Adds gas-duck.test.js tests.
danjm Sep 9, 2018
7de3f22
Connects remained of the gas customization component to redux.
danjm Sep 13, 2018
b567c78
Integrate gas buttons with the send screen.
danjm Sep 13, 2018
5354325
Test updates and additions for button integration with send screen.
danjm Sep 20, 2018
b95eb30
Adds redesign for the customize gas advanced tab.
danjm Sep 20, 2018
6f8e2b1
Clean up for advanced gas tab customization changes.
danjm Oct 9, 2018
6dd1028
Lint and unit test fixes.
danjm Oct 10, 2018
0ba6f7d
Adds not yet functional gas price chart.
danjm Sep 20, 2018
2dbae58
Gas price chart improvements, redesign, bug fixes, and set up to rece…
danjm Oct 3, 2018
a2bbf50
Read only connection of gas price chart to redux
danjm Oct 9, 2018
cd32c58
Complete integration of gas chart with redux.
danjm Oct 10, 2018
aa798cc
Add control arrows to advanced gas tab inputs.
danjm Oct 10, 2018
6f04061
Clean up gas chart code.
danjm Oct 23, 2018
d0619b0
Update tests, plus some lint fixes, for gas-price-chart
danjm Oct 23, 2018
d14af83
Improve data management and tests for gas-modal-page-container price …
danjm Oct 24, 2018
3ced3c9
Clean up for mmui-i11-custom-gas-price-chart branch
danjm Oct 25, 2018
3162a27
Redesign of gas customization basic tab.
danjm Oct 25, 2018
9b9a2cc
Adds createSpeedUpTransaction to txController
danjm Oct 26, 2018
e3f015c
Adds speed up slide-in gas customization sidebar
danjm Oct 26, 2018
79de7a4
Connect gas price chart to gas station api.
danjm Oct 24, 2018
a8259f7
Update e2e tests for new gas customization modal.
danjm Nov 5, 2018
b70886a
Fixes for components that break e2e gas customization tests, plus uni…
danjm Nov 5, 2018
8c8359c
Remove gas customization integration tests (in favour of e2e tests)
danjm Nov 6, 2018
b7f873b
Add gas data to integration test json data set.
danjm Nov 7, 2018
a44596e
Add c3 and d3 to the separate dependencies bundle.
danjm Nov 8, 2018
d5411e7
Make gas customization modal responsive.
danjm Nov 8, 2018
4111e9f
Improve responsiveness of customize speed up slider.
danjm Nov 15, 2018
fe53515
Fix "fastest" translation message; change to sentence case
danjm Nov 13, 2018
7f2c5c0
Uses more reliable api on main send screen; caches basic api results …
danjm Nov 13, 2018
7ffea92
Add loading spinners when waiting for APIs in the gas customization m…
danjm Nov 13, 2018
f8ffdae
Modify results of API data to better fit gas chart: remove outliers, …
danjm Nov 13, 2018
75d7545
Clear custom gas data on hiding of gas customization modal.
danjm Nov 13, 2018
d8e41a6
Final gas customization fixes
danjm Nov 27, 2018
8194309
Fix styling of send screen in extension view when hex data on.
danjm Dec 3, 2018
d199650
Merge pull request #5704 from MetaMask/new-gas-customize-feature-bran…
danjm Dec 4, 2018
6a0993a
Replace height: 100% rule with workaround for flexbox quirks
whymarrh Dec 5, 2018
7ade47d
Merge pull request #5882 from whymarrh/fix-main-container-wrapper-height
whymarrh Dec 5, 2018
80d7be0
Fill in more Polish message translations
whymarrh Dec 6, 2018
161fdcf
Update lockfile to fix errors
whymarrh Dec 6, 2018
9beac97
circleci: Disable npm audit when installing packages
whymarrh Dec 6, 2018
c7f46f7
npm audit fix
whymarrh Dec 6, 2018
c804185
circleci: Replace nsp with npm audit
whymarrh Dec 6, 2018
b6789a6
Remove beefy dependency and its usages
whymarrh Dec 6, 2018
855c8b2
npm uninstall open
whymarrh Dec 6, 2018
ac6b0bd
Update ganache-core to mitigate vuln
whymarrh Dec 6, 2018
d7c8a30
Deduplicate package.json file
whymarrh Dec 6, 2018
246dcf6
Fix race condition in network controller lookup() method.
danjm Dec 6, 2018
0c8c6db
Merge pull request #5891 from whymarrh/npm-audit
whymarrh Dec 7, 2018
347b26f
Merge pull request #5890 from whymarrh/pl-i18n
whymarrh Dec 7, 2018
575fb60
Merge pull request #5892 from MetaMask/fix-net-version-race-condition
tmashuang Dec 7, 2018
d8ab9cc
Group transactions by nonce (#5886)
alextsg Dec 9, 2018
49971e9
fix formatting of 32-byte strings in personal_sign (#5878)
NoahZinsmeister Dec 10, 2018
0d8fa92
Bump json-rpc-engine to v4.0.0
danfinlay Dec 10, 2018
14bd599
Bump package lock, mostly to https links
danfinlay Dec 10, 2018
1fbdce8
Improve ux for low gas price set (#5862)
danjm Dec 10, 2018
3bfd4d1
Merge branch 'develop' into i5846-ProviderCrashes
danfinlay Dec 10, 2018
dde2397
Show Failed transaction in the browser notification for on-chain fail…
alextsg Dec 11, 2018
5ab3f5b
Changelog and version bump for 5.2.0
danjm Dec 11, 2018
ce23891
Merge pull request #5908 from MetaMask/i5846-ProviderCrashes-changelog
tmashuang Dec 11, 2018
d6fa967
Merge pull request #5902 from MetaMask/i5846-ProviderCrashes
tmashuang Dec 11, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
- run:
name: Install npm 6 + deps via npm
command: |
sudo npm install -g npm@6 && npm install --no-save
sudo npm install -g npm@6 && npm install --no-save --no-audit
- persist_to_workspace:
root: .
paths:
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
at: .
- run:
name: Test
command: npx nsp check
command: sudo npm install -g npm@6 && npm audit

test-e2e-beta-drizzle:
docker:
Expand Down
7 changes: 0 additions & 7 deletions .nsprc

This file was deleted.

10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

## Current Develop Branch

## 5.2.0 Mon Dec 11 2018

- [#5704] Implements new gas customization features for sending, confirming and speeding up transactions
- [#5886] Groups transactions - speed up, cancel and original - by nonce in the transaction history list
- [#5892] bugfix: eliminates infinite spinner issues caused by switching quickly from a loading network that ultimately fails to resolve
- [$5902] bugfix: provider crashes caused caching issues in `json-rpc-engine`. Fixed in (https://github.com/MetaMask/json-rpc-engine/commit/6de511afbd03ccef4550ea43ff4010b7d7a84039)

## 5.1.0 Mon Dec 03 2018

- [#5860](https://github.com/MetaMask/metamask-extension/pull/5860): Fixed an infinite spinner bug.
Expand All @@ -11,12 +18,13 @@

## 5.0.4 Thu Nov 29 2018

- [#5878](https://github.com/MetaMask/metamask-extension/pull/5878): Formats 32-length byte strings passed to personal_sign as hex, rather than UTF8.
- [#5840](https://github.com/MetaMask/metamask-extension/pull/5840): transactions/tx-gas-utils - add the acctual response for eth_getCode for NO_CONTRACT_ERROR's && add a debug object to simulationFailed
- [#5848](https://github.com/MetaMask/metamask-extension/pull/5848): Soften accusatory language on phishing warning
- [#5835](https://github.com/MetaMask/metamask-extension/pull/5835): Open full-screen UI on install
- Locked versions for some dependencies to avoid possible issues from event-stream hack.
- [#5831](https://github.com/MetaMask/metamask-extension/pull/5831): Hide app-header when provider request pending
- [#5786](https://github.com/MetaMask/metamask-extension/pull/5786): * transactions - autofill gasPrice for retry attempts with either the recomened gasprice or a %10 bump
- [#5786](https://github.com/MetaMask/metamask-extension/pull/5786): * transactions - autofill gasPrice for retry attempts with either the recomened gasprice or a %10 bump
- [#5801](https://github.com/MetaMask/metamask-extension/pull/5801): transactions - ensure err is defined when setting tx failed
- [#5792](https://github.com/MetaMask/metamask-extension/pull/5792): Consider HW Wallets for signTypedMessage
- [#5829](https://github.com/MetaMask/metamask-extension/pull/5829): Show disabled cursor in .network-disabled state
Expand Down
93 changes: 84 additions & 9 deletions app/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
"confirmClear": {
"message": "Are you sure you want to clear approved websites?"
},
"contractInteraction": {
"message": "Contract Interaction"
},
"clearApprovalDataSuccess": {
"message": "Approved website data cleared successfully."
},
Expand Down Expand Up @@ -65,6 +68,9 @@
"address": {
"message": "Address"
},
"advancedOptions": {
"message": "Advanced Options"
},
"addCustomToken": {
"message": "Add custom token"
},
Expand All @@ -80,12 +86,18 @@
"addAcquiredTokens": {
"message": "Add the tokens you've acquired using MetaMask"
},
"advanced": {
"message": "Advanced"
},
"amount": {
"message": "Amount"
},
"amountPlusGas": {
"message": "Amount + Gas"
},
"amountPlusTxFee": {
"message": "Amount + TX Fee"
},
"appDescription": {
"message": "Ethereum Browser Extension",
"description": "The description of the application"
Expand Down Expand Up @@ -115,6 +127,9 @@
"available": {
"message": "Available"
},
"average": {
"message": "Average"
},
"back": {
"message": "Back"
},
Expand All @@ -127,6 +142,9 @@
"balanceIsInsufficientGas": {
"message": "Insufficient balance for current gas total"
},
"basic": {
"message": "Basic"
},
"beta": {
"message": "BETA"
},
Expand Down Expand Up @@ -170,6 +188,9 @@
"cancellationGasFee": {
"message": "Cancellation Gas Fee"
},
"cancelled": {
"message": "Cancelled"
},
"cancelN": {
"message": "Cancel all $1 transactions"
},
Expand Down Expand Up @@ -303,6 +324,9 @@
"customGas": {
"message": "Customize Gas"
},
"customGasSubTitle": {
"message": "Increasing fee may decrease processing times, but it is not guaranteed."
},
"customToken": {
"message": "Custom Token"
},
Expand Down Expand Up @@ -427,6 +451,15 @@
"failed": {
"message": "Failed"
},
"fast": {
"message": "Fast"
},
"fastest": {
"message": "Fastest"
},
"feeChartTitle": {
"message": "Live Transaction Fee Predictions"
},
"fiat": {
"message": "Fiat",
"description": "Exchange type"
Expand Down Expand Up @@ -481,6 +514,9 @@
"gasPrice": {
"message": "Gas Price (GWEI)"
},
"gasPriceNoDenom": {
"message": "Gas Price"
},
"gasPriceCalculation": {
"message": "We calculate the suggested gas prices based on network success rates."
},
Expand Down Expand Up @@ -689,6 +725,9 @@
"missingYourTokens": {
"message": "Don't see your tokens?"
},
"minutesShorthand": {
"message": "Min"
},
"myAccounts": {
"message": "My Accounts"
},
Expand Down Expand Up @@ -755,6 +794,12 @@
"optionalNickname": {
"message": "Nickname (optional)"
},
"newTotal": {
"message": "New Total"
},
"newTransactionFee": {
"message": "New Transaction Fee"
},
"next": {
"message": "Next"
},
Expand Down Expand Up @@ -820,6 +865,9 @@
"parameters": {
"message": "Parameters"
},
"originalTotal": {
"message": "Original Total"
},
"password": {
"message": "Password"
},
Expand Down Expand Up @@ -993,6 +1041,9 @@
"save": {
"message": "Save"
},
"slow": {
"message": "Slow"
},
"saveAsCsvFile": {
"message": "Save as CSV File"
},
Expand All @@ -1018,6 +1069,9 @@
"secretPhrase": {
"message": "Enter your secret twelve word phrase here to restore your vault."
},
"secondsShorthand": {
"message": "Sec"
},
"seedPhraseReq": {
"message": "Seed phrases are 12 words long"
},
Expand All @@ -1039,6 +1093,9 @@
"send": {
"message": "Send"
},
"sendAmount": {
"message": "Send Amount"
},
"sendETH": {
"message": "Send ETH"
},
Expand Down Expand Up @@ -1126,6 +1183,12 @@
"speedUpSubtitle": {
"message": "Increase your gas price to attempt to overwrite and speed up your transaction"
},
"speedUpCancellation": {
"message": "Speed up this cancellation"
},
"speedUpTransaction": {
"message": "Speed up this transaction"
},
"status": {
"message": "Status"
},
Expand Down Expand Up @@ -1212,29 +1275,38 @@
"message": "transaction"
},
"transactionConfirmed": {
"message": "Transaction confirmed on $2."
"message": "Transaction confirmed at $2."
},
"transactionCreated": {
"message": "Transaction created with a value of $1 on $2."
"message": "Transaction created with a value of $1 at $2."
},
"transactionWithNonce": {
"message": "Transaction $1"
},
"transactionDropped": {
"message": "Transaction dropped on $2."
"message": "Transaction dropped at $2."
},
"transactionSubmitted": {
"message": "Transaction submitted on $2."
"message": "Transaction submitted with gas fee of $1 at $2."
},
"transactionResubmitted": {
"message": "Transaction resubmitted with gas fee increased to $1 at $2"
},
"transactionUpdated": {
"message": "Transaction updated on $2."
"message": "Transaction updated at $2."
},
"transactionUpdatedGas": {
"message": "Transaction updated with a gas price of $1 on $2."
"message": "Transaction updated with a gas fee of $1 at $2."
},
"transactionErrored": {
"message": "Transaction encountered an error."
},
"transactionCancelAttempted": {
"message": "Transaction cancel attempted with gas fee of $1 at $2"
},
"transactionCancelSuccess": {
"message": "Transaction successfully cancelled at $2"
},
"transactions": {
"message": "transactions"
},
Expand All @@ -1244,12 +1316,18 @@
"transactionErrorNoContract": {
"message": "Trying to call a function on a non-contract address."
},
"transactionFee": {
"message": "Transaction Fee"
},
"transactionMemo": {
"message": "Transaction memo (optional)"
},
"transactionNumber": {
"message": "Transaction Number"
},
"transactionTime": {
"message": "Transaction Time"
},
"transfer": {
"message": "Transfer"
},
Expand Down Expand Up @@ -1293,9 +1371,6 @@
"unknown": {
"message": "Unknown"
},
"unknownFunction": {
"message": "Unknown Function"
},
"unknownNetwork": {
"message": "Unknown Private Network"
},
Expand Down
9 changes: 9 additions & 0 deletions app/_locales/pl/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@
"clickCopy": {
"message": "Kliknij żeby skopiować"
},
"clickToAdd": {
"message": "Przycisnij $1, aby dodać go do swojego konta"
},
"close": {
"message": "Zamknij"
},
Expand Down Expand Up @@ -337,6 +340,9 @@
"exchangeRate": {
"message": "Kurs wymiany"
},
"expandView": {
"message": "Rozwiń widok"
},
"exportPrivateKey": {
"message": "Eksportuj klucz prywatny"
},
Expand Down Expand Up @@ -596,6 +602,9 @@
"min": {
"message": "Minimum"
},
"missingYourTokens": {
"message": "Nie widzisz swoich token?"
},
"myAccounts": {
"message": "Moje konta"
},
Expand Down
3 changes: 3 additions & 0 deletions app/images/icons/cancelled.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions app/images/icons/confirm.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions app/images/icons/error.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions app/images/icons/new.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading