Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Increase click area for arrows #5264

Merged
merged 1 commit into from Sep 15, 2018
Merged

Improvement: Increase click area for arrows #5264

merged 1 commit into from Sep 15, 2018

Conversation

rabaut
Copy link

@rabaut rabaut commented Sep 14, 2018

Creates a wrapper div for the arrow buttons and places the onClick handler there. The wrapper div allows the click area to be much larger which fixes the issue of clicks appearing not to work. It also appeared buggy since cursor: pointer; was being applied to the container of both arrows, but the onClick area was only the actual icon.

This may fix #5163

@rabaut
Copy link
Author

rabaut commented Sep 14, 2018

Before

old-buttons

After

new-buttons

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @raboid!

@whymarrh whymarrh merged commit cd28dbb into MetaMask:develop Sep 15, 2018
@rabaut rabaut deleted the issue-5163 branch September 15, 2018 23:29
@tmashuang tmashuang mentioned this pull request Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gas price incrementing buttons are finnicky
2 participants