-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QR Code Scanner #4897
Merged
Merged
QR Code Scanner #4897
Changes from 32 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2e50348
added instascan pkg
brunobar79 0940ecd
added camera snippet injection to inpage.js
brunobar79 0209148
fixes
brunobar79 f7ad978
camera working back and forth
brunobar79 d5929e5
added qr code scanner icon in send transaction
brunobar79 74fd6d1
working without injection
brunobar79 eeb902d
decent UI
brunobar79 4759915
fix spinner and qr icon
brunobar79 6cd4bc9
working without permission issues
brunobar79 ea028e7
fully working without tweaking ext. permission
brunobar79 d4a15f2
added webrtc-adapter for browser compat
brunobar79 69f4c8c
fix merge conflicts
brunobar79 d65d018
restore platform/extension.js
brunobar79 bea1cf3
clean up
brunobar79 6886429
fix linting errors
brunobar79 4de8f5b
fix dependencies
brunobar79 acfcdf5
fix unit tests
brunobar79 b6592ba
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
brunobar79 4339f04
use existing modals
brunobar79 d2368d6
clean up css
brunobar79 34617a2
copy
brunobar79 b673a7a
kill camera stream when unmouting
brunobar79 edb1547
send to fullscreen if no permission from popup
brunobar79 710b4e2
added crossbrowser support and error handling
brunobar79 caa9e20
lint
brunobar79 7a40072
lint
brunobar79 94a8979
fix
brunobar79 71ef4d8
design complete
brunobar79 af97ba1
clear qr code data before scanning
brunobar79 e9a0feb
fixed issue with input
brunobar79 b1ddaaf
lint
brunobar79 ef9435e
restore qr
brunobar79 2e0916d
fix merge conflicts
brunobar79 c6b7e46
code review changes
brunobar79 a46cf39
update package-lock.json
brunobar79 cbbd0d3
lint
brunobar79 f269021
add submit button type
brunobar79 656afee
fix merge conflicts
brunobar79 d0ccc59
add comment
brunobar79 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
@import './customize-gas/index'; | ||
|
||
@import './qr-scanner/index'; | ||
|
||
.modal-container { | ||
width: 100%; | ||
height: 100%; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import QrScanner from './qr-scanner.container' | ||
module.exports = QrScanner |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty small, nit-picky request, but could you make it explicit what properties are in qrCodeData? In the absence of both tests and formal documentation for this file, make properties explicit makes the code a bit more self documenting. See, for example, the
showQrView
,updateSendTo
orsetCurrentCurrency
functions in this file.In this case I am thinking of some variation of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @danjm this is a good suggestion. The main reason why I can't do that it's because I have 2 types of values: {type, values} and also null.
I need to set it to null once the view handled the code. If you have any other suggestion / workaround for that I'm happy to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option might be to add a docblock to the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up following @whymarrh's suggestion. Thanks!