Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show multichain network icons #30276

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 12, 2025

Description

This adds the multichain network icon mapping to the getImageForChainId function so network icons can be displayed for non-EVM assets

Open in GitHub Codespaces

Related issues

Fixes:N/A

Manual testing steps

  1. EVM network asset pickers should not be affected
  2. Changes in multichain networks will only be visible after Swaps/Bridge supports them (separate PR)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [2a10363]
Page Load Metrics (1669 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39521491609311149
domContentLoaded15112115164713264
load15212121166913565
domInteractive157337178
backgroundConnect97329199
firstReactRender1583382512
getState55612115
initialActions01000
loadScripts10711583119311857
setupStore66116189
uiStartup17022457190215876
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 97 Bytes (0.00%)
  • common: 26 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review February 12, 2025 21:59
@micaelae micaelae requested review from a team as code owners February 12, 2025 21:59
@metamaskbot
Copy link
Collaborator

Builds ready [342cbbb]
Page Load Metrics (1571 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1451177415829244
domContentLoaded1410175515539646
load1449177515719546
domInteractive249038189
backgroundConnect96023178
firstReactRender1580502612
getState5451094
initialActions01000
loadScripts972128811169144
setupStore66516189
uiStartup16462075180111354
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 97 Bytes (0.00%)
  • common: 26 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 41b7fc9 Feb 12, 2025
73 checks passed
@micaelae micaelae deleted the mms1867-multichain-network-icons branch February 12, 2025 23:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants