-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove circular dependencies in ui/components/component-library/*
#30267
Merged
+320
−519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [b089972]
Page Load Metrics (1853 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/component-library/*
b089972
to
7079e67
Compare
Builds ready [7079e67]
Page Load Metrics (1708 ± 77 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d2c365d]
Page Load Metrics (1626 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
HowardBraham
approved these changes
Feb 12, 2025
Builds ready [33d3e11]
Page Load Metrics (1727 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
georgewrmarshall
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Apologies for introducing these
darkwing
approved these changes
Feb 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.13.0
Issue or pull request that will be included in release 12.13.0
team-extension-platform
Extension Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.
This PR changes some imports to
import type { ... }
imports, which don't count for circular dependencies, and changes other from referencing it's own parentindex.ts
file to just referencing the main file with the component it needs directly.