Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding storybook story for snap install warning component #30237

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Feb 10, 2025

Description

This PR adds a Storybook story for the SnapInstallWarning component, improving coverage and making it easier to view and develop in isolation.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to Components/App/Snaps/SnapInstallWarning
  3. Click "Open Warning Modal"
  4. Verify that the SnapInstallWarning renders

Screenshots/Recordings

Before

N/A - New component stories

After

after720.mov

Known issue with the local provider in storybook

Screenshot 2025-02-10 at 2 07 30 PM

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards
  • I've completed the PR template to the best of my ability
  • I've included tests through Storybook stories
  • I've documented my code using TypeScript types and story documentation
  • I've applied the right labels on the PR

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed)
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots

@georgewrmarshall georgewrmarshall self-assigned this Feb 10, 2025
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Feb 10, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall force-pushed the fix/snaps-install-warning-story branch 5 times, most recently from 1e66bd1 to c2ff8ce Compare February 10, 2025 22:11
@georgewrmarshall georgewrmarshall force-pushed the fix/snaps-install-warning-story branch from c2ff8ce to 5836390 Compare February 10, 2025 22:11
@metamaskbot
Copy link
Collaborator

Builds ready [5836390]
Page Load Metrics (1690 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26319821630341164
domContentLoaded14621972166713665
load14701983169014168
domInteractive23113372412
backgroundConnect878282211
firstReactRender1596382612
getState45114147
initialActions01000
loadScripts10021486119511957
setupStore76220209
uiStartup16482337194517383
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall marked this pull request as ready for review February 10, 2025 22:59
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner February 10, 2025 22:59
@georgewrmarshall georgewrmarshall changed the title chore: adding snap install warning story chore: adding storybook story for snap install warning component Feb 10, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 0ab294f Feb 12, 2025
90 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/snaps-install-warning-story branch February 12, 2025 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants