test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) #30090

chloeYue · 2025-02-04T11:29:56Z

Description

First PR to migrate dapp interaction e2e tests to TypeScript and the Page Object Model.

Specs migrated:

test/e2e/tests/dapp-interactions/block-explorer.spec.js
test/e2e/tests/dapp-interactions/dapp-interactions.spec.js

Page classes created:

test/e2e/page-objects/pages/confirmations/redesign/add-network-confirmations.ts
test/e2e/page-objects/pages/confirmations/redesign/connect-account-confirmation.ts
test/e2e/page-objects/pages/mocked-page.ts

Related issues

Fixes:

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-04T11:30:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-04T12:07:03Z

Builds ready [cc7d329]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1751 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1532	1997	1751	123	59
		domContentLoaded	1516	1986	1724	124	60
		load	1535	2013	1751	126	61
		domInteractive	23	95	41	20	10
		backgroundConnect	9	73	36	23	11
		firstReactRender	16	177	42	39	19
		getState	4	141	20	31	15
		initialActions	0	1	0	0	0
		loadScripts	1032	1534	1268	125	60
		setupStore	7	64	17	18	9
		uiStartup	1723	2730	2031	218	105

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-04T12:59:24Z

Builds ready [2823ea7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1890 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1556	2239	1901	185	89
		domContentLoaded	1529	2170	1856	172	82
		load	1544	2235	1890	178	86
		domInteractive	26	104	46	26	12
		backgroundConnect	13	96	37	25	12
		firstReactRender	16	167	57	38	18
		getState	5	62	17	18	9
		initialActions	0	1	0	0	0
		loadScripts	1068	1709	1372	154	74
		setupStore	8	80	24	23	11
		uiStartup	1777	3062	2245	308	148

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-07T03:54:19Z

Builds ready [84ea252]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1814 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	345	2116	1740	355	170
		domContentLoaded	1509	2064	1789	149	72
		load	1550	2081	1814	144	69
		domInteractive	25	102	39	22	10
		backgroundConnect	11	64	30	19	9
		firstReactRender	17	100	38	27	13
		getState	4	62	17	17	8
		initialActions	0	0	0	0	0
		loadScripts	1076	1490	1306	124	60
		setupStore	7	77	21	22	11
		uiStartup	1739	2543	2085	203	97

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-12T10:53:01Z

Builds ready [e09dcf8]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1728 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1531	2092	1726	150	72
		domContentLoaded	1518	2008	1690	139	67
		load	1532	2103	1728	152	73
		domInteractive	24	87	37	18	9
		backgroundConnect	10	104	41	26	13
		firstReactRender	16	91	40	25	12
		getState	4	59	17	16	8
		initialActions	0	1	0	0	0
		loadScripts	1025	1535	1214	130	62
		setupStore	6	65	15	16	8
		uiStartup	1714	2360	1985	163	78

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/page-objects/pages/confirmations/redesign/connect-account-confirmation.ts

test/e2e/page-objects/pages/home/activity-list.ts

seaona

Overall looks good 🔥 Added a small suggestion to mitigate future flakiness

…ount-confirmation.ts Co-authored-by: seaona <[email protected]>

Co-authored-by: seaona <[email protected]>

metamaskbot · 2025-02-12T20:53:48Z

Builds ready [1507d67]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1671 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	327	2079	1605	333	160
		domContentLoaded	1438	2024	1648	145	70
		load	1449	2081	1671	157	76
		domInteractive	17	149	48	33	16
		backgroundConnect	8	60	24	16	8
		firstReactRender	15	78	43	27	13
		getState	4	56	13	17	8
		initialActions	0	0	0	0	0
		loadScripts	1019	1550	1207	135	65
		setupStore	7	57	11	11	5
		uiStartup	1693	2359	1913	160	77

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/constants.ts

Co-authored-by: Danica Shen <[email protected]>

metamaskbot · 2025-02-13T12:25:32Z

Builds ready [6b538b3]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1684 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1512	1971	1693	112	54
		domContentLoaded	1459	1956	1662	118	57
		load	1470	1971	1684	122	58
		domInteractive	24	120	49	28	14
		backgroundConnect	10	71	27	18	9
		firstReactRender	16	103	32	26	12
		getState	5	56	18	19	9
		initialActions	0	0	0	0	0
		loadScripts	1036	1453	1208	108	52
		setupStore	6	64	19	20	9
		uiStartup	1721	2239	1944	148	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 47 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chloeYue added 5 commits January 21, 2025 12:05

migrate tests

9c048f7

Merge branch 'main' into chloe-tests-dapp

3720474

Merge branch 'main' into chloe-tests-dapp

87aed53

fix lint

0c4c7f8

test

cc7d329

chloeYue added team-extension-platform Extension Platform team e2e-test End to end test for the MetaMask extension team-qa QA team labels Feb 4, 2025

chloeYue requested a review from a team February 4, 2025 11:29

chloeYue self-assigned this Feb 4, 2025

chloeYue requested a review from a team as a code owner February 4, 2025 11:29

chloeYue marked this pull request as draft February 4, 2025 11:30

chloeYue changed the title ~~test: Chloe tests dapp~~ test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) Feb 4, 2025

revert yml changes

2823ea7

chloeYue removed the request for review from a team February 4, 2025 12:21

Merge branch 'main' into chloe-tests-dapp

84ea252

chloeYue added 2 commits February 12, 2025 11:15

Merge branch 'main' into chloe-tests-dapp

b14fb33

merge main

e09dcf8

chloeYue marked this pull request as ready for review February 12, 2025 10:52

seaona reviewed Feb 12, 2025

View reviewed changes

test/e2e/page-objects/pages/confirmations/redesign/connect-account-confirmation.ts Outdated Show resolved Hide resolved

seaona reviewed Feb 12, 2025

View reviewed changes

test/e2e/page-objects/pages/home/activity-list.ts Outdated Show resolved Hide resolved

seaona reviewed Feb 12, 2025

View reviewed changes

hjetpoluru previously approved these changes Feb 12, 2025

View reviewed changes

Update test/e2e/page-objects/pages/confirmations/redesign/connect-acc…

b804450

…ount-confirmation.ts Co-authored-by: seaona <[email protected]>

chloeYue dismissed hjetpoluru’s stale review via b804450 February 12, 2025 20:17

Update test/e2e/page-objects/pages/home/activity-list.ts

1507d67

Co-authored-by: seaona <[email protected]>

chloeYue requested review from seaona and hjetpoluru February 13, 2025 10:24

seaona previously approved these changes Feb 13, 2025

View reviewed changes

DDDDDanica reviewed Feb 13, 2025

View reviewed changes

test/e2e/constants.ts Outdated Show resolved Hide resolved

DDDDDanica previously approved these changes Feb 13, 2025

View reviewed changes

Update test/e2e/constants.ts

eb618c9

Co-authored-by: Danica Shen <[email protected]>

chloeYue dismissed stale reviews from DDDDDanica and seaona via eb618c9 February 13, 2025 10:48

DDDDDanica previously approved these changes Feb 13, 2025

View reviewed changes

seaona previously approved these changes Feb 13, 2025

View reviewed changes

chloeYue enabled auto-merge February 13, 2025 11:07

fix test

6b538b3

chloeYue dismissed stale reviews from seaona and DDDDDanica via 6b538b3 February 13, 2025 11:49

chloeYue disabled auto-merge February 13, 2025 11:54

seaona approved these changes Feb 13, 2025

View reviewed changes

chloeYue requested a review from DDDDDanica February 13, 2025 12:41

DDDDDanica approved these changes Feb 13, 2025

View reviewed changes

DDDDDanica added this pull request to the merge queue Feb 13, 2025

Merged via the queue into main with commit 9ec8eaf Feb 13, 2025
73 checks passed

DDDDDanica deleted the chloe-tests-dapp branch February 13, 2025 16:18

github-actions bot locked and limited conversation to collaborators Feb 13, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) #30090

test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) #30090

chloeYue commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 12, 2025

seaona left a comment

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 13, 2025

test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) #30090

test: [POM] Migrate dapp interaction e2e tests to TS and Page Object Model (part1) #30090

Conversation

chloeYue commented Feb 4, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 4, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 12, 2025

seaona left a comment

Choose a reason for hiding this comment

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 13, 2025

chloeYue commented Feb 4, 2025 •

edited

Loading