Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove supported chains check #29773

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Jan 17, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3940

Manual testing steps

  1. Go to the test dapp
  2. Perform transactions and signatures in the section PPOM - Malicious Transactions and Signatures
  3. Test one previous supported chain and another chain outside the list below:
// previous supported chains
ARBITRUM = '0xa4b1'
AVALANCHE = '0xa86a'
BASE = '0x2105'
BERACHAIN = '0x138d4'
BSC = '0x38'
LINEA_MAINNET = '0xe708'
MAINNET = '0x1'
METACHAIN_ONE = '0x1b6e6'
OPBNB = '0xcc'
OPTIMISM = '0xa'
POLYGON = '0x89'
SCROLL = '0x82750'
SEPOLIA = '0xaa36a7'
ZKSYNC_ERA = '0x144'

Screenshots/Recordings

Screencast.from.2025-01-28.14-56-38.webm

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Jan 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam marked this pull request as ready for review January 27, 2025 13:29
@vinistevam vinistevam requested a review from a team as a code owner January 27, 2025 13:29
@vinistevam vinistevam force-pushed the fix/remove-supported-chains-check-ppom branch from d1b80a2 to 770c98d Compare January 27, 2025 14:10
@vinistevam vinistevam force-pushed the fix/remove-supported-chains-check-ppom branch from 4c3fcf1 to 748ed7c Compare January 28, 2025 10:29
@metamaskbot
Copy link
Collaborator

Builds ready [d5b9e39]
Page Load Metrics (1917 ± 161 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35825531831470226
domContentLoaded149924931892328157
load153225551917335161
domInteractive24178573617
backgroundConnect980342311
firstReactRender16177533918
getState5101302814
initialActions01000
loadScripts104919321396269129
setupStore7101172110
uiStartup172132272253457219
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -491 Bytes (-0.01%)
  • ui: 0 Bytes (0.00%)
  • common: -826 Bytes (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants