Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MetaMask / metamask-extension Public

Notifications You must be signed in to change notification settings
Fork 5.1k
Star 12.3k

Code
Issues 2k
Pull requests 281
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Open popup before estimateGas finishes#2962

Merged

danfinlay merged 6 commits intomasterMetaMask/metamask-extension:masterfrom open-popupMetaMask/metamask-extension:open-popupCopy head branch name to clipboard

Jan 16, 2018

+55-17

Conversation Commits6 (6)Checks Files changed

Commits

Commits on Jan 14, 2018

add a loading spinner to conf-tx view
frankiebee
committed
transactions - emit 'newUnapprovedTx' before estimateGas finishes
frankiebee
committed
test - create ethJsQuery stub
frankiebee
committed
test - fix to match expected behavior
frankiebee
committed

Commits on Jan 15, 2018

add to CHANGELOG.md
frankiebee
committed
Merge branch 'master' into open-popup
frankiebee
authored

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.