chore: Remove toggle to turn on/off Per Dapp Selected Network Feature

[adonesky1]

Description

The "Select networks for each site" preference toggle on the experimental settings page has been live for many releases now since the toggle has been turned on by default. We meant to remove it a while ago.

This PR removes this toggle and integrates new versions of the QueuedRequestController and SelectedNetworkController which remove the backend logic it operated.

• We have delayed the updates to the controllers side because of some mobile side requirements. See this PR for more context:

We are not yet ready to release per-dapp selected network functionality on the mobile client and with this change there is no clean way to MetaMask/metamask-mobile#12434 (comment) in the mobile client without having the Domains state starting to populate and possibly become corrupt since its not being consumed by/updated by the frontend in the expected way and may need to be migrated away when its time to actually start using the controller.

Without this revert the @MetaMask/wallet-framework team is blocked from completing their goal to get both clients up to the latest versions of all controllers.

Beyond the fact that this removal is overdue, another reason we should remove this now is that having this setting when turned off is causing a bug with wallet_switchEthereumChain and the interaction with the new chain permissions feature.

Related issues

Fixes: #2844

Manual testing steps

1. Go to experimental tab of settings
2. See that there is no longer a toggleable preference called "Selected Networks for each site"
3. See that Per Dapp Selected Network Functionality is still on by default

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

Builds ready [ac9677b]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1600 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1442	1796	1600	87	42
		domContentLoaded	1407	1766	1571	84	40
		load	1443	1786	1600	87	42
		domInteractive	21	188	43	38	18
		backgroundConnect	11	58	26	15	7
		firstReactRender	16	99	50	32	16
		getState	4	56	11	15	7
		initialActions	0	0	0	0	0
		loadScripts	1033	1323	1176	76	36
		setupStore	6	75	16	22	11
		uiStartup	1637	2452	1940	248	119

[jiexi]

can this hook just be a noop now instead? or do we have to immediately call the listener for some other reason?

[adonesky1]

done here: c6dc756

[jiexi]

looks like there's a ts and js version of this file?

[adonesky1]

gooood catch!

[adonesky1]

Removed here: c6dc756

[metamaskbot]

Builds ready [c6dc756]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1636 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	399	1848	1524	375	180
		domContentLoaded	1492	1806	1613	95	45
		load	1510	1846	1636	101	49
		domInteractive	22	80	36	15	7
		backgroundConnect	6	55	22	13	6
		firstReactRender	16	85	33	24	12
		getState	5	46	12	13	6
		initialActions	0	1	0	0	0
		loadScripts	1101	1382	1211	91	43
		setupStore	6	53	12	13	6
		uiStartup	1691	2089	1868	114	55