Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove network modal #28765

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: remove network modal #28765

merged 2 commits into from
Nov 27, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 27, 2024

Description

PR to remove network modal

image

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to home page and click Network selector and go to 'Additional networks' section
  2. Click on "Add" and then click on "approve"
  3. You should not see another network modal "You're now using.."

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri marked this pull request as ready for review November 27, 2024 11:34
@sahar-fehri sahar-fehri requested a review from a team as a code owner November 27, 2024 11:34
@metamaskbot
Copy link
Collaborator

Builds ready [1beb0d2]
Page Load Metrics (1795 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15381988179012359
domContentLoaded15211941175911656
load15401991179512359
domInteractive269339199
backgroundConnect155633147
firstReactRender16106312612
getState57419199
initialActions01000
loadScripts1113145013009646
setupStore679202211
uiStartup17012231201113464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -8.23 KiB (-0.11%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 27, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit d457539 Nov 27, 2024
77 checks passed
@sahar-fehri sahar-fehri deleted the fix/remove-network-modal branch November 27, 2024 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants