Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: on UI side filtering put typed sign V4 requests for which decoding data is displayed #28762

Merged
merged 15 commits into from
Nov 27, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 27, 2024

Description

Filter our typed sign requests for which decoding api results are displayed.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3682

Manual testing steps

  1. Enable signature decoding locally
  2. Submit request for permit signatures on test dapp of supported seaport signatures
  3. It should work as expected

Screenshots/Recordings

Screenshot 2024-11-27 at 3 14 40 PM Screenshot 2024-11-27 at 3 14 31 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Nov 27, 2024
@jpuri jpuri requested review from a team as code owners November 27, 2024 09:45
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2b10428]
Page Load Metrics (1953 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16222407195817283
domContentLoaded16072313190516981
load16242361195316981
domInteractive2798442010
backgroundConnect10119443115
firstReactRender17115372914
getState678402412
initialActions01000
loadScripts11511748140114569
setupStore7181132
uiStartup184527092203215103
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.63 KiB (0.02%)
  • common: 56 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b6472c2]
Page Load Metrics (1573 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13971902158012560
domContentLoaded13881857155111656
load13971893157312761
domInteractive217536189
backgroundConnect1068252110
firstReactRender1699563014
getState484212612
initialActions00000
loadScripts1028137211468842
setupStore686172311
uiStartup16502378185219192
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.59 KiB (0.02%)
  • common: 56 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [65be533]
Page Load Metrics (1548 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14381918155611756
domContentLoaded1422183015239746
load1438184515489646
domInteractive237135178
backgroundConnect11441894
firstReactRender1599463416
getState589252713
initialActions01000
loadScripts1036138811338239
setupStore65212136
uiStartup15722225181218589
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.8 KiB (0.02%)
  • common: 56 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 4785373 Nov 27, 2024
75 checks passed
@jpuri jpuri deleted the decoding_api_request_filtering branch November 27, 2024 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants