Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @metamask/message-manager to v11 #28758

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 27, 2024

Description

The @metamask/message-manager package has been updated from v10 to v11. The only breaking change is the removal of exports previously used by the signature controller which are no longer used.

Changelog: https://github.com/MetaMask/core/blob/main/packages/message-manager/CHANGELOG.md#1100

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Nov 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +1 273 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 27, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@Gudahtt Gudahtt marked this pull request as ready for review November 27, 2024 05:26
@Gudahtt Gudahtt requested review from a team as code owners November 27, 2024 05:26
@metamaskbot
Copy link
Collaborator

Builds ready [f9ac6d6]
Page Load Metrics (1732 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29121161596451217
domContentLoaded15062086171015675
load15172116173215976
domInteractive237641178
backgroundConnect94620136
firstReactRender1796542512
getState583162211
initialActions01000
loadScripts10551513124912761
setupStore613821
uiStartup16952414194620398
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -41.51 KiB (-0.71%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ea2c709]
Page Load Metrics (1568 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14442146159015876
domContentLoaded13952128154015876
load14072144156816579
domInteractive238043178
backgroundConnect988222110
firstReactRender15183454321
getState574222211
initialActions01000
loadScripts10261571114911656
setupStore590243014
uiStartup157924081866262126
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -41.51 KiB (-0.71%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the signature-controller exports are not being used. Looks good.

Gudahtt and others added 2 commits November 27, 2024 19:28
The `@metamask/message-manager` package has been updated from v10 to
v11. The only breaking change is the removal of exports previously
used by the signature controller which are no longer used.

Changelog: https://github.com/MetaMask/core/blob/main/packages/message-manager/CHANGELOG.md#1100
@metamaskbot
Copy link
Collaborator

Builds ready [a71e199]
Page Load Metrics (2257 ± 139 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31329521984691332
domContentLoaded183228922223281135
load184029512257290139
domInteractive269143189
backgroundConnect1186372110
firstReactRender1710332199
getState502671114120
initialActions00000
loadScripts137923011711238115
setupStore7441184
uiStartup214634892614387186
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -41.51 KiB (-0.72%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit b963edc Nov 28, 2024
75 checks passed
@Gudahtt Gudahtt deleted the bump-message-manager branch November 28, 2024 00:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants