Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Network filter must respect PORTFOLIO_VIEW feature flag #28626

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 21, 2024

Description

When feature flag is omitted, we should not show tokens across all chains, only the currentNetwork.chainId

Open in GitHub Codespaces

Related issues

Fixes: Multichain tokens being rendered when PORTFOLIO_VIEW feature is off (unexpected)

Manual testing steps

With feature flag off:

yarn webpack --watch

When running the app, the tokens displayed should always belong to the globally selected network.

With feature flag on:

PORTFOLIO_VIEW=1 yarn webpack --watch

When running the app, you should see all tokens from all added networks, when "All Networks" filter is selected. When "Current filter" is selected, you should see only tokens for the globally selected network.

Screenshots/Recordings

Before

Screenshot 2024-11-21 at 8 18 08 PM

After

Screen.Recording.2024-11-21.at.12.31.04.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title fix: When feature flag is off, we still need to filter by selected chain fix: Network filter must respect PORTFOLIO_VIEW feature flag Nov 21, 2024
@gambinish gambinish marked this pull request as ready for review November 21, 2024 20:48
@gambinish gambinish requested review from a team as code owners November 21, 2024 20:48
@metamaskbot
Copy link
Collaborator

Builds ready [109611f]
Page Load Metrics (1994 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17672403199216479
domContentLoaded17542346196014871
load17682404199416378
domInteractive158939168
backgroundConnect11159313316
firstReactRender963841507234
getState563232110
initialActions01000
loadScripts12661718144612259
setupStore675182110
uiStartup198227772293225108
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -165 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 175d429 Nov 21, 2024
84 checks passed
@gambinish gambinish deleted the fix/network-filter-initializer-feature-flag branch November 21, 2024 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants