fix: Network filter must respect PORTFOLIO_VIEW
feature flag
#28626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When feature flag is omitted, we should not show tokens across all chains, only the
currentNetwork.chainId
Related issues
Fixes: Multichain tokens being rendered when
PORTFOLIO_VIEW
feature is off (unexpected)Manual testing steps
With feature flag off:
yarn webpack --watch
When running the app, the tokens displayed should always belong to the globally selected network.
With feature flag on:
PORTFOLIO_VIEW=1 yarn webpack --watch
When running the app, you should see all tokens from all added networks, when "All Networks" filter is selected. When "Current filter" is selected, you should see only tokens for the globally selected network.
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-21.at.12.31.04.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist