Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add nullish fallback for tokenNetwork filter Object.keys #28617

Closed
wants to merge 1 commit into from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 21, 2024

Description

Reported crash on homepage due to Object.keys on an undefined value. I haven't been able to replciate, but here is a temporary fix while we find a more legitimate solution.

Open in GitHub Codespaces

Related issues

Fixes: https://consensys.slack.com/archives/CTQAGKY5V/p1732199614277099

Manual testing steps

  1. Go to homepage
  2. Click around tabs, make sure app doesn't crash

Screenshots/Recordings

Before

Screenshot 2024-11-21 at 14 33 24

After

Screen.Recording.2024-11-21.at.6.41.19.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [7625322]
Page Load Metrics (1922 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16872178192913263
domContentLoaded16722126190412359
load16902172192213163
domInteractive30105552411
backgroundConnect96122147
firstReactRender571631112813
getState563232211
initialActions01000
loadScripts12101602141110550
setupStore66317199
uiStartup18892448214714067
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 24 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish marked this pull request as ready for review November 21, 2024 15:27
@gambinish gambinish requested a review from a team as a code owner November 21, 2024 15:27
@gambinish
Copy link
Contributor Author

Closing since it looks like the bug raised was related to a weird caching issue on local. I'll reopen this if this bug resurfaces.

@gambinish gambinish closed this Nov 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants