Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: limit playwright install to chromium browser only #28580

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Nov 20, 2024

Description

Storybook CI jobs are failing due to the playwright install step timing out due to an AWS issue. We may be able to work around this issue by reducing the number of browsers we download. We only use chromium, so this PR limits it to just chromium

Open in GitHub Codespaces

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davidmurdoch davidmurdoch marked this pull request as ready for review November 20, 2024 22:22
@davidmurdoch davidmurdoch requested review from kumavis and a team as code owners November 20, 2024 22:22
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmurdoch davidmurdoch added this pull request to the merge queue Nov 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [79c0d2d]
Page Load Metrics (2102 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41426742015415199
domContentLoaded18242647206619191
load18362682210219694
domInteractive18152492914
backgroundConnect980352411
firstReactRender562961115326
getState44204913818
initialActions01000
loadScripts13272060155316981
setupStore686182110
uiStartup215030662452224108
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit d5c0aaa Nov 20, 2024
81 checks passed
@davidmurdoch davidmurdoch deleted the ci-limit-playwright-install-to-chromium branch November 20, 2024 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants