chore: Remove toggle to turn on/off Per Dapp Selected Network Feature #28577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
changed the title
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected] |
4 tasks
adonesky1
changed the title
adonesky1
force-pushed
the
ad/remove-per-dapp-selected-network-preference-toggle
branch
from
b23245a
to
8d37a93
Compare
adonesky1
added a commit
to MetaMask/core
that referenced
this pull request
Nov 22, 2024
…ed Network Feature (#4941) ## Explanation The "Select networks for each site" preference toggle on the experimental settings page has been live for many releases now since the toggle has been turned on by default. We meant to remove it a while ago. <img width="770" alt="Screenshot 2024-11-19 at 10 58 04 AM" src="https://github.com/user-attachments/assets/aeca2483-c019-4f9f-b44e-520d10db9eee"> This PR removes the togglability of per dapp selected network from the `SelectedNetworkController` and `QueuedRequestMiddleware` The extension to integrate this change will also have to implement a migration to remove this state. Another reason we should remove this now is that having this setting turned off is [causing a bug](MetaMask/metamask-extension#28441) to result with `wallet_switchEthereumChain` and the interaction between the new chain permissions feature and the absence of queuing. ## References Extension PR w/ preview builds of this PR (plus full removal of the toggle): MetaMask/metamask-extension#28577 When integrated in the extension will resolve this issue: MetaMask/metamask-extension#28441 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/queued-request-controller` - **REMOVED**: `createQueuedRequestMiddleware` no longer expects a `useRequestQueue` property in its param options. ### `@metamask/selected-network-controller` - **REMOVED**: SelectedNetworkController constructure no longer expects either `useRequestQueuePreference` or `onPreferencesStateChange` params ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
jiexi
reviewed
Nov 22, 2024
app/scripts/migrations/132.ts
Outdated
| isObject(state.PreferencesController) && | ||
| hasProperty(state.PreferencesController, 'preferences') && | ||
| isObject(state.PreferencesController.preferences) && | ||
| hasProperty(state.PreferencesController.preferences, 'useRequestQueue') |
There was a problem hiding this comment.
probably can delete without checking if it exists. doesn't really matter either way though
|
beautiful! just needs the core release cut and usage here |
adonesky1
force-pushed
the
ad/remove-per-dapp-selected-network-preference-toggle
branch
from
f94712a
to
dc9ae6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Select networks for each site" preference toggle on the experimental settings page has been live for many releases now since the toggle has been turned on by default. We meant to remove it a while ago.
This PR removes this toggle and integrates new versions of the QueuedRequestController and SelectedNetworkController which remove the backend logic it operated.
Beyond the fact that this removal is overdue, another reason we should remove this now is that having this setting when turned off is causing a bug with
wallet_switchEthereumChainand the interaction with the new chain permissions feature.References
core side changes: MetaMask/core#4941
#28441
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist