Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cherry pick asset-list-control-bar updates #28575

Merged
merged 12 commits into from
Nov 21, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 20, 2024

Description

Cherry picks design updates for AssetListControlBar introduced from #28386 separately in it's own PR to help minimize diff in main feature branch.

Also includes unit test and e2e updates impacted from these changes.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Run with feature flag and without feature flag:

yarn webpack --watch
PORTFOLIO_VIEW=1 yarn webpack --watch

Validate that sort works, validate that import works, validate that refresh list works.

Screenshots/Recordings

Without feature flag:

Screen.Recording.2024-11-20.at.11.15.55.AM.mov

With feature flag (network filter not yet integrated)

Screen.Recording.2024-11-20.at.11.19.12.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title Refactor: Cherry pick asset-list-control-bar updates Cherry pick asset-list-control-bar updates Nov 20, 2024
@gambinish gambinish changed the title Cherry pick asset-list-control-bar updates refactor: Cherry pick asset-list-control-bar updates Nov 20, 2024
@gambinish gambinish marked this pull request as ready for review November 20, 2024 22:54
@gambinish gambinish requested review from a team as code owners November 20, 2024 22:54
@gambinish gambinish enabled auto-merge November 20, 2024 23:21
@gambinish gambinish added this pull request to the merge queue Nov 20, 2024
@gambinish gambinish removed this pull request from the merge queue due to a manual request Nov 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f893bfb]
Page Load Metrics (2119 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint18192711212119694
domContentLoaded17862662207819292
load18112715211919995
domInteractive31226644120
backgroundConnect985402512
firstReactRender633851147838
getState44199963015
initialActions01000
loadScripts13462019157915273
setupStore68212168
uiStartup211630562475249119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 66 Bytes (0.00%)
  • ui: -2.59 KiB (-0.03%)
  • common: 22 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit bd2248d Nov 21, 2024
75 checks passed
@gambinish gambinish deleted the refactor/portfolio-view-import-token-update branch November 21, 2024 00:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants