-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Cherry pick asset-list-control-bar updates #28575
Merged
gambinish
merged 12 commits into
develop
from
refactor/portfolio-view-import-token-update
Nov 21, 2024
Merged
refactor: Cherry pick asset-list-control-bar updates #28575
gambinish
merged 12 commits into
develop
from
refactor/portfolio-view-import-token-update
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
approved these changes
Nov 20, 2024
bergeron
approved these changes
Nov 20, 2024
jonybur
approved these changes
Nov 20, 2024
Builds ready [f893bfb]
Page Load Metrics (2119 ± 95 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picks design updates for
AssetListControlBar
introduced from #28386 separately in it's own PR to help minimize diff in main feature branch.Also includes unit test and e2e updates impacted from these changes.
Related issues
Fixes:
Manual testing steps
Run with feature flag and without feature flag:
yarn webpack --watch
PORTFOLIO_VIEW=1 yarn webpack --watch
Validate that sort works, validate that import works, validate that refresh list works.
Screenshots/Recordings
Without feature flag:
Screen.Recording.2024-11-20.at.11.15.55.AM.mov
With feature flag (network filter not yet integrated)
Screen.Recording.2024-11-20.at.11.19.12.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist