feat: adding e2e for signature decoding api and enable it in extension #28423

jpuri · 2024-11-12T13:50:17Z

Description

adding e2e for signature decoding api and enable it in extension

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3625, https://github.com/MetaMask/MetaMask-planning/issues/3692

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-12T13:50:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri · 2024-11-13T09:41:33Z

The PR can not be merged till the env variable are enabled for main build in develop branch.

jpuri · 2024-11-27T15:23:15Z

builds.yml

  # URL of the decoding API used to provide additional data from signature requests
-  - DECODING_API_URL: null
+  - DECODING_API_URL: 'https://qtgdj2huxh.execute-api.us-east-2.amazonaws.com/uat/v1'


We are still pointing to uat, as prod is currently broken

jpuri · 2024-11-27T15:29:26Z

@metamaskbot update-policies

metamaskbot · 2024-11-27T15:41:00Z

No policy changes

… into decoding_e2e

metamaskbot · 2024-11-27T17:44:01Z

Builds ready [f339dca]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1605 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1389	1918	1610	127	61
		domContentLoaded	1376	1889	1582	119	57
		load	1387	1909	1605	127	61
		domInteractive	23	78	32	13	6
		backgroundConnect	11	98	26	20	9
		firstReactRender	15	100	42	29	14
		getState	4	66	17	20	10
		initialActions	0	1	0	0	0
		loadScripts	998	1422	1163	101	48
		setupStore	6	64	12	15	7
		uiStartup	1537	2212	1858	190	91

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 70 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-27T23:55:51Z

Builds ready [6c8c6e7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1920 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1754	2271	1924	130	62
		domContentLoaded	1716	2245	1899	128	62
		load	1756	2273	1920	130	62
		domInteractive	26	65	36	10	5
		backgroundConnect	9	61	27	16	8
		firstReactRender	16	47	22	8	4
		getState	49	115	91	20	10
		initialActions	0	1	0	0	0
		loadScripts	1274	1737	1447	115	55
		setupStore	6	10	8	1	1
		uiStartup	1963	2583	2188	153	73

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 70 Bytes (0.00%)
common: 0 Bytes (0.00%)

… into decoding_e2e

ui/pages/confirmations/hooks/useTypesSignSimulationEnabledInfo.ts

ui/pages/confirmations/hooks/useTypesSignSimulationEnabledInfo.test.ts

test/e2e/tests/confirmations/signatures/permit.spec.ts

app/scripts/metamask-controller.js

Gudahtt · 2024-11-28T14:16:47Z

privacy-snapshot.json

@@ -48,6 +48,8 @@
  "price.api.cx.metamask.io",
  "proxy.api.cx.metamask.io",
  "proxy.dev-api.cx.metamask.io",
+  "qtgdj2huxh.execute-api.us-east-2.amazonaws.com",
+  "https://signature-insights.api.cx.metamask.io",


Where is this entry coming from?

These are UAT and PROD url for signature decoding api.

I removed PROD url for now, we can add it back once we switch to prod instance

metamaskbot · 2024-11-28T15:12:36Z

Builds ready [8b83e99]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1849 ± 111 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1583	2370	1856	225	108
		domContentLoaded	1576	2309	1816	218	105
		load	1584	2362	1849	230	111
		domInteractive	24	62	40	14	7
		backgroundConnect	8	137	34	36	17
		firstReactRender	15	96	32	22	11
		getState	24	86	58	23	11
		initialActions	0	1	0	0	0
		loadScripts	1199	1831	1382	182	87
		setupStore	6	82	20	23	11
		uiStartup	1781	2798	2153	273	131

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 1.75 KiB (0.02%)
common: 0 Bytes (0.00%)

… into decoding_e2e

Gudahtt

LGTM! Reviewed just the privacy snapshot, build config, and metamask-controller

metamaskbot · 2024-11-28T16:19:32Z

Builds ready [e1cfcd6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2032 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	296	2170	1833	521	250
		domContentLoaded	1787	2417	2009	141	68
		load	1808	2432	2032	141	68
		domInteractive	27	73	48	16	7
		backgroundConnect	8	76	25	21	10
		firstReactRender	16	80	26	15	7
		getState	50	121	101	17	8
		initialActions	0	1	0	0	0
		loadScripts	1296	1872	1550	129	62
		setupStore	7	34	10	6	3
		uiStartup	2061	2745	2342	174	84

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 55 Bytes (0.00%)
ui: 1.75 KiB (0.02%)
common: 0 Bytes (0.00%)

jpuri added the team-confirmations Push issues to confirmations team label Nov 12, 2024

jpuri requested review from a team as code owners November 12, 2024 13:50

jpuri marked this pull request as draft November 13, 2024 05:44

Base automatically changed from native_value_display to develop November 22, 2024 00:50

jpuri force-pushed the decoding_e2e branch from 03d9d8c to a1b6d9f Compare November 26, 2024 13:23

jpuri changed the base branch from develop to decoding_api_request_filtering November 27, 2024 14:51

jpuri marked this pull request as ready for review November 27, 2024 14:58

jpuri requested a review from a team as a code owner November 27, 2024 14:58

jpuri commented Nov 27, 2024

View reviewed changes

jpuri force-pushed the decoding_e2e branch from 9112edc to 8698533 Compare November 27, 2024 16:05

Base automatically changed from decoding_api_request_filtering to develop November 27, 2024 16:06

Adding e2e for signature decoding

2f2708f

jpuri force-pushed the decoding_e2e branch from 8698533 to 2f2708f Compare November 27, 2024 16:07

jpuri enabled auto-merge November 27, 2024 16:08

jpuri added 4 commits November 27, 2024 22:30

update

4c5ee47

Merge branch 'develop' into decoding_e2e

008f037

update

387b64a

Merge branch 'decoding_e2e' of github.com:MetaMask/metamask-extension…

f339dca

… into decoding_e2e

Merge branch 'develop' into decoding_e2e

6c8c6e7

jpuri added 4 commits November 28, 2024 14:55

update

43e57e7

Merge branch 'decoding_e2e' of github.com:MetaMask/metamask-extension…

53e354b

… into decoding_e2e

update

25c2b71

update

15d97c7

matthewwalsh0 requested changes Nov 28, 2024

View reviewed changes

jpuri added 2 commits November 28, 2024 18:49

update

bedbed1

update

34cec6e

jpuri requested a review from matthewwalsh0 November 28, 2024 13:26

matthewwalsh0 previously approved these changes Nov 28, 2024

View reviewed changes

OGPoyraz previously approved these changes Nov 28, 2024

View reviewed changes

Merge branch 'develop' into decoding_e2e

8b83e99

Gudahtt reviewed Nov 28, 2024

View reviewed changes

app/scripts/metamask-controller.js Show resolved Hide resolved

Gudahtt reviewed Nov 28, 2024

View reviewed changes

jpuri changed the title ~~chore: adding e2e for signature decoding api~~ chore: adding e2e for signature decoding api and enable it in extension Nov 28, 2024

jpuri changed the title ~~chore: adding e2e for signature decoding api and enable it in extension~~ feat: adding e2e for signature decoding api and enable it in extension Nov 28, 2024

Merge branch 'develop' into decoding_e2e

f2678cf

jpuri requested a review from Gudahtt November 28, 2024 15:15

jpuri added 2 commits November 28, 2024 20:56

update

e33a044

Merge branch 'decoding_e2e' of github.com:MetaMask/metamask-extension…

e1cfcd6

… into decoding_e2e

jpuri dismissed stale reviews from matthewwalsh0 and OGPoyraz via e1cfcd6 November 28, 2024 15:26

jpuri requested review from matthewwalsh0 and OGPoyraz November 28, 2024 15:27

Gudahtt approved these changes Nov 28, 2024

View reviewed changes

matthewwalsh0 approved these changes Nov 28, 2024

View reviewed changes

OGPoyraz approved these changes Nov 28, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 28, 2024

Merged via the queue into develop with commit 9b067c8 Nov 28, 2024
75 checks passed

jpuri deleted the decoding_e2e branch November 28, 2024 16:29

github-actions bot locked and limited conversation to collaborators Nov 28, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding e2e for signature decoding api and enable it in extension #28423

feat: adding e2e for signature decoding api and enable it in extension #28423

jpuri commented Nov 12, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024

jpuri commented Nov 13, 2024

jpuri Nov 27, 2024

jpuri commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

Gudahtt Nov 28, 2024

jpuri Nov 28, 2024

jpuri Nov 28, 2024

metamaskbot commented Nov 28, 2024

Gudahtt left a comment

metamaskbot commented Nov 28, 2024

feat: adding e2e for signature decoding api and enable it in extension #28423

feat: adding e2e for signature decoding api and enable it in extension #28423

Conversation

jpuri commented Nov 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 12, 2024

jpuri commented Nov 13, 2024

jpuri Nov 27, 2024

Choose a reason for hiding this comment

jpuri commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

Gudahtt Nov 28, 2024

Choose a reason for hiding this comment

jpuri Nov 28, 2024

Choose a reason for hiding this comment

jpuri Nov 28, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 28, 2024

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 28, 2024

jpuri commented Nov 12, 2024 •

edited

Loading