test: Fix data deletion e2e tests

[Gudahtt]

Description

The "Delete MetaMetrics Data" e2e tests were recently broken due to a change in CI configuration. The code-under-test was written to always use the environment variable present for the data deletion source ID and endpoint, but the e2e tests wrongly assumed that it would never be present.

The service has been updated to use the fallback values for e2e test builds, even if the environment variable is present.

Related issues

Fixes CI failure currently on all branches (e.g. https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/108823/workflows/cbc57b89-8647-4219-b413-24df4fdad95c/jobs/4070258 )

This bug was introduced in #24503, but only began causing failures recently when CI configuration was updated with these new environment variables.

Manual testing steps

See that the data deletion e2e tests succeed even with both data deletion environment variables set.

Screenshots/Recordings

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[hjetpoluru]

LGTM! Thanks for the quick action.

[metamaskbot]

Builds ready [2755584]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1677 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	370	1924	1607	305	147
		domContentLoaded	1502	1914	1655	116	56
		load	1510	1926	1677	116	56
		domInteractive	16	97	42	20	9
		backgroundConnect	7	68	23	19	9
		firstReactRender	46	127	79	21	10
		getState	4	48	12	13	6
		initialActions	0	1	0	0	0
		loadScripts	1089	1440	1218	100	48
		setupStore	10	77	23	20	9
		uiStartup	1693	2105	1857	136	65

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 16 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)