only check nonces of transactions who's from address match the txMeta #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress match the txMeta
|
Is it possible for us to write tests for this? I'd like for us to get into the habit of writing tests for our PRs. |
2-am-zzz
suggested changes
Dec 28, 2017
test/unit/pending-tx-test.js
Outdated
| } | ||
| }) | ||
|
|
||
| it('should return false', function (done) { |
There was a problem hiding this comment.
Can we clarify when these should return false?
test/unit/pending-tx-test.js
Outdated
| .catch(done) | ||
| }) | ||
|
|
||
| it('should return true', function (done) { |
There was a problem hiding this comment.
Same for here when they return true. Sorry for being pedantic, but future generations will thank us.
2-am-zzz
approved these changes
Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2810
the issue seemed to be that we were checking against all confirmed transactions instead of just the ones for that specific address