-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate MetaMetricsController to BaseControllerV2 #28113
feat: migrate MetaMetricsController to BaseControllerV2 #28113
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
fc42304
to
578139f
Compare
578139f
to
cc4012a
Compare
57db26d
to
2040439
Compare
…ler-to-base-controller-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared the JavaScript and TypeScript versions of the controller and everything looks pretty good. Most of my comments were minor, except for perhaps using ?? null
to default MetaMetrics properties that would otherwise be undefined
.
ui/components/multichain/pages/send/components/quote-card/index.tsx
Outdated
Show resolved
Hide resolved
…ler-to-base-controller-v2
…ler-to-base-controller-v2
…ler-to-base-controller-v2
…ler-to-base-controller-v2
…ler-to-base-controller-v2
…ion-metametrics-controller-to-base-controller-v2
…ler-to-base-controller-v2
…ion-metametrics-controller-to-base-controller-v2
…ler-to-base-controller-v2
Builds ready [281415b]
Page Load Metrics (1818 ± 48 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Description
This PR migrates MetaMetricsController to inherit from BaseController V2
Related issues
Fixes: #25925
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist