feat: update copy for 'Default settings' #27821

jonybur · 2024-10-14T12:02:17Z

Description

Updates the copy for the onboarding message screen and the onboarding settings screen.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3496

Manual testing steps

For the following scenarios:
a. Wallet created w backup
b. Wallet created w/o backup
c. Wallet imported
The copy of the success screens and the settings screen should be updated as shown in the Screenshots:

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-14T12:02:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

andreahaku

LGTM

andreahaku

LGTM

andreahaku

LGTM

metamaskbot · 2024-10-14T19:40:23Z

Builds ready [f2a1c03]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1811 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1541	2151	1814	145	70
		domContentLoaded	1532	2083	1776	136	65
		load	1540	2103	1811	142	68
		domInteractive	18	81	47	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 16 Bytes (0.00%)

metamaskbot · 2024-10-15T00:36:29Z

Builds ready [53198e6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2092 ± 143 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	363	2692	1988	481	231
		domContentLoaded	1624	2616	2054	306	147
		load	1672	2621	2092	297	143
		domInteractive	20	102	49	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 16 Bytes (0.00%)

… jb-3496

metamaskbot · 2024-10-15T15:23:43Z

Builds ready [c8530e3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1812 ± 162 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	235	2995	1670	578	277
		domContentLoaded	1543	2935	1781	323	155
		load	1548	3016	1812	337	162
		domInteractive	15	77	38	16	8
		backgroundConnect	7	91	34	26	13
		firstReactRender	45	194	85	33	16
		getState	4	68	14	17	8
		initialActions	0	1	0	0	0
		loadScripts	1092	2467	1317	304	146
		setupStore	10	74	32	24	11
		uiStartup	1699	3300	2029	385	185

… jb-3496

andreahaku

LGTM

sonarqubecloud · 2024-10-15T15:44:01Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-15T16:18:15Z

Builds ready [d0e8863]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1792 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1547	1972	1790	120	58
		domContentLoaded	1540	1961	1756	113	54
		load	1547	1973	1792	109	52
		domInteractive	15	171	48	32	15
		backgroundConnect	9	92	41	29	14
		firstReactRender	47	200	99	46	22
		getState	5	68	21	22	10
		initialActions	0	1	0	0	0
		loadScripts	1114	1442	1294	89	43
		setupStore	11	97	33	28	14
		uiStartup	1686	2416	2042	174	84

metamaskbot · 2024-10-15T16:21:08Z

Builds ready [d0e8863]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1792 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1547	1972	1790	120	58
		domContentLoaded	1540	1961	1756	113	54
		load	1547	1973	1792	109	52
		domInteractive	15	171	48	32	15
		backgroundConnect	9	92	41	29	14
		firstReactRender	47	200	99	46	22
		getState	5	68	21	22	10
		initialActions	0	1	0	0	0
		loadScripts	1114	1442	1294	89	43
		setupStore	11	97	33	28	14
		uiStartup	1686	2416	2042	174	84

Update copy

41f6c34

jonybur requested a review from a team as a code owner October 14, 2024 12:02

github-actions bot added the team-wallet-ux label Oct 14, 2024

Update test

4af2800

jonybur requested a review from a team as a code owner October 14, 2024 12:18

NidhiKJha previously approved these changes Oct 14, 2024

View reviewed changes

andreahaku previously approved these changes Oct 14, 2024

View reviewed changes

Fix tests

2b57da2

jonybur dismissed stale reviews from andreahaku and NidhiKJha via 2b57da2 October 14, 2024 15:15

jonybur requested review from NidhiKJha and andreahaku October 14, 2024 15:22

andreahaku previously approved these changes Oct 14, 2024

View reviewed changes

NidhiKJha previously approved these changes Oct 14, 2024

View reviewed changes

jonybur enabled auto-merge October 14, 2024 15:31

Fix test

f2a1c03

jonybur dismissed stale reviews from NidhiKJha and andreahaku via f2a1c03 October 14, 2024 15:42

jonybur requested review from andreahaku and NidhiKJha October 14, 2024 15:43

andreahaku previously approved these changes Oct 14, 2024

View reviewed changes

NidhiKJha previously approved these changes Oct 14, 2024

View reviewed changes

Merge branch 'develop' into jb-3496

53198e6

jonybur added this pull request to the merge queue Oct 15, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024

jonybur added this pull request to the merge queue Oct 15, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024

jonybur added this pull request to the merge queue Oct 15, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024

Merge branch 'develop' into jb-3496

c8530e3

jonybur enabled auto-merge October 15, 2024 15:04

jonybur added this pull request to the merge queue Oct 15, 2024

jonybur added 2 commits October 15, 2024 16:18

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

df05de2

… jb-3496

Merge branch 'jb-3496' of github.com:MetaMask/metamask-extension into…

a98641c

… jb-3496

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 15, 2024

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

d0e8863

… jb-3496

jonybur dismissed stale reviews from NidhiKJha and andreahaku via d0e8863 October 15, 2024 15:32

jonybur requested review from andreahaku and NidhiKJha October 15, 2024 15:38

NidhiKJha approved these changes Oct 15, 2024

View reviewed changes

andreahaku approved these changes Oct 15, 2024

View reviewed changes

jonybur added this pull request to the merge queue Oct 15, 2024

Merged via the queue into develop with commit b410e09 Oct 15, 2024
78 checks passed

jonybur deleted the jb-3496 branch October 15, 2024 16:33

github-actions bot locked and limited conversation to collaborators Oct 15, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024

gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update copy for 'Default settings' #27821

feat: update copy for 'Default settings' #27821

jonybur commented Oct 14, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Oct 14, 2024

andreahaku left a comment

andreahaku left a comment

andreahaku left a comment

metamaskbot commented Oct 14, 2024

metamaskbot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

andreahaku left a comment

sonarqubecloud bot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

feat: update copy for 'Default settings' #27821

feat: update copy for 'Default settings' #27821

Conversation

jonybur commented Oct 14, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 14, 2024

andreahaku left a comment

Choose a reason for hiding this comment

andreahaku left a comment

Choose a reason for hiding this comment

andreahaku left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 14, 2024

metamaskbot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

andreahaku left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 15, 2024

Quality Gate passed

metamaskbot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

jonybur commented Oct 14, 2024 •

edited by github-actions bot

Loading