-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding typed sign support for NFT permit #27796
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
confirmation: SignatureRequestType, | ||
) => { | ||
if (!confirmation) { | ||
return {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, would it be more explicit to return undefined
here so we can insist primary type and standard are always returned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not get this point exactly, I return empty object here for ease of destructuring the result.
Builds ready [d002def]
Page Load Metrics (1714 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
if (primaryType !== TypedSignSignaturePrimaryTypes.PERMIT) { | ||
return undefined; | ||
} | ||
console.log(confirmation, confirmation?.msgParams?.data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
Quality Gate failedFailed conditions |
Would it make sense to add an e2e test? |
@pedronfigueiredo : yep that is good idea, let me do that. |
Builds ready [f8f74d0]
Page Load Metrics (1861 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Adding support for NFT permit signature request.
Related issues
Fixes: #27396
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist