Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace 'transaction fees' with 'network fees' in the insufficie… #27762

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Oct 10, 2024

…nt funds alert copy

Description

A copy change in the insufficient funds alert.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Sorry, something went wrong.

…nt funds alert copy
@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 10, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Oct 10, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners October 10, 2024 13:08
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [942f2ca]
Page Load Metrics (1930 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32224631843391188
domContentLoaded16602365188616881
load16762471193017986
domInteractive14110452311
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 1 Bytes (0.00%)
  • common: -3 Bytes (-0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 7d7f017 Oct 10, 2024
85 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3369 branch October 10, 2024 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 10, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants