-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue with Snap title in Snap Authorship Header #27752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
changed the title
Fix: issue with Snap title in Snap Authorship Header
fix: issue with Snap title in Snap Authorship Header
Oct 10, 2024
GuillaumeRx
reviewed
Oct 10, 2024
ui/components/app/snaps/snap-authorship-header/snap-authorship-header.js
Outdated
Show resolved
Hide resolved
@david0xd You'll need to update some snapshots before this will pass CI |
FrederikBolding
approved these changes
Oct 10, 2024
Builds ready [4090886]
Page Load Metrics (1957 ± 126 ms)
Bundle size diffs
|
GuillaumeRx
approved these changes
Oct 10, 2024
matthewwalsh0
approved these changes
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2024
david0xd
force-pushed
the
dd/fix-snap-header-title
branch
from
October 10, 2024 12:52
4090886
to
6c88e12
Compare
Quality Gate passedIssues Measures |
Builds ready [6c88e12]
Page Load Metrics (2083 ± 125 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 10, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with Snap name in Snap Authorship Header.
Description
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist