Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain: Change Chain from Asset Details for Send and Swap #27732

Closed
wants to merge 2 commits into from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Oct 9, 2024

Description

This PR outlines switching network when the user clicks "Send" or "Swap" from a given asset details page. Since we may not be on the network of the token, we may need to switch network.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner October 9, 2024 16:50
@darkwing darkwing marked this pull request as draft October 9, 2024 16:50
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title Multichain: Change Chain from Asset Details Multichain: Change Chain from Asset Details for Send and Swap Oct 9, 2024
@darkwing darkwing force-pushed the multichain-token-details-actions branch from 719e5e5 to b75a868 Compare October 12, 2024 00:55
@darkwing darkwing added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Oct 16, 2024
@gambinish
Copy link
Contributor

Closing this as it's mostly already been integrated on develop. I've also introduced some of the code from this PR, along with some additional unit test coverage here: #28740

@gambinish gambinish closed this Nov 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants