Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add transaction flow and details sections #27654

Merged
merged 9 commits into from
Oct 17, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Oct 7, 2024

Description

Adds two new sections for the wallet initiated ERC20 token transfer redesigned confirmation.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3220

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2024-10-07 at 11 04 58

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 7, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Oct 7, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners October 7, 2024 10:11
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3220 branch 3 times, most recently from 8f29230 to bdddb4f Compare October 9, 2024 13:03
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3219 branch 4 times, most recently from 34f2b40 to 2203d10 Compare October 10, 2024 10:42
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3220 branch 2 times, most recently from dc9604c to a666b99 Compare October 10, 2024 15:29
Base automatically changed from pnf/3219 to develop October 10, 2024 16:45
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3220 branch 2 times, most recently from f02f9de to d624dcb Compare October 15, 2024 13:31
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3220 branch 2 times, most recently from 1f20c44 to 181634e Compare October 16, 2024 13:29
matthewwalsh0
matthewwalsh0 previously approved these changes Oct 16, 2024
vinistevam
vinistevam previously approved these changes Oct 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5cd1c40]
Page Load Metrics (1704 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148423741714221106
domContentLoaded147323201669221106
load148623871704229110
domInteractive21175423416
backgroundConnect885382512
firstReactRender42198925024
getState571172010
initialActions01000
loadScripts103719041250216104
setupStore1096383216
uiStartup165125581926245118
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 5.81 KiB (0.08%)
  • common: 43 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3220 branch 4 times, most recently from 99d0ce3 to 147e2d9 Compare October 17, 2024 08:40
vinistevam
vinistevam previously approved these changes Oct 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3d5e95a]
Page Load Metrics (1947 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33025591859421202
domContentLoaded159024301900212102
load159826931947254122
domInteractive30127502311
backgroundConnect8299496230
firstReactRender492131204722
getState5134323316
initialActions01000
loadScripts11671867141218086
setupStore11125383215
uiStartup185936182255403193
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.22 KiB (0.08%)
  • common: 43 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit dc48117 Oct 17, 2024
76 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3220 branch October 17, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 17, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants