Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply flex to Snaps buttons only when containing images and icons #27564

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 2, 2024

Description

Fixes an alignment problem introduced recently when trying to correctly align images and icons nested in Snaps buttons.

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/snaps#2780

Screenshots/Recordings

Before

image

After

image

image

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Oct 2, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 2, 2024 13:25
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 2, 2024
Copy link

sonarqubecloud bot commented Oct 2, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [5a5ca9f]
Page Load Metrics (1887 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16522458188418991
domContentLoaded16452362185617584
load16532464188718890
domInteractive147439168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit 453e043 Oct 2, 2024
88 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-flexbox-being-applied-to-snap-buttons-with-text branch October 2, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default vertical alignment for child components changed from Flask 12.2 to 12.3
5 participants