Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flaky permit test #27450

Merged
merged 3 commits into from
Sep 27, 2024
Merged

test: Fix flaky permit test #27450

merged 3 commits into from
Sep 27, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Sep 27, 2024

Description

This PR fixes: test/e2e/tests/confirmations/signatures/permit.spec.ts

Issue was that e2e were passing in CI, but failing locally. The changes here provide a few helpers to prevent this flakey behavior.

The issue was first flagged here: #27184 (comment)

Follow up slack thread here: https://consensys.slack.com/archives/C03ETQA9EPK/p1727373903173259

Open in GitHub Codespaces

Related issues

Fixes: test/e2e/tests/confirmations/signatures/permit.spec.ts when running chrome e2e locally

Manual testing steps

  1. Running permit.spec.ts should pass e2e chrome locally and in CI

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner September 27, 2024 10:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 27, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d641d06]
Page Load Metrics (1736 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27823021676383184
domContentLoaded14992228170919493
load150622991736217104
domInteractive194996010350
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I am linking our slack conversation here for tracking purposes: https://consensys.slack.com/archives/C03ETQA9EPK/p1727373903173259

Copy link

sonarcloud bot commented Sep 27, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [7d78d3c]
Page Load Metrics (1793 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44920821720318153
domContentLoaded16112072177012761
load16202090179314168
domInteractive21190513617
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish merged commit 1bd0b9e into develop Sep 27, 2024
77 checks passed
@gambinish gambinish deleted the e2e-permit branch September 27, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants