-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix flaky permit test #27450
test: Fix flaky permit test #27450
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [d641d06]
Page Load Metrics (1736 ± 104 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I am linking our slack conversation here for tracking purposes: https://consensys.slack.com/archives/C03ETQA9EPK/p1727373903173259
Quality Gate passedIssues Measures |
Builds ready [7d78d3c]
Page Load Metrics (1793 ± 68 ms)
Bundle size diffs
|
Description
This PR fixes:
test/e2e/tests/confirmations/signatures/permit.spec.ts
Issue was that e2e were passing in CI, but failing locally. The changes here provide a few helpers to prevent this flakey behavior.
The issue was first flagged here: #27184 (comment)
Follow up slack thread here: https://consensys.slack.com/archives/C03ETQA9EPK/p1727373903173259
Related issues
Fixes:
test/e2e/tests/confirmations/signatures/permit.spec.ts
when running chrome e2e locallyManual testing steps
permit.spec.ts
should pass e2e chrome locally and in CIScreenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist