fix: Confirm Page test failing in CI/CD

[digiwand]

Description

Running ui/pages/confirmations/confirm/confirm.test.tsx locally passes, but running it in our CI/CD fails. This PR updates the test to pass CI/CD

I'm currently unsure where the discrepancy lies between local vs. ci/cd here. Why is the text found once locally and twice in CI/CD? Fixing this as so to unblock other PRs

Error:

 FAIL  ui/pages/confirmations/confirm/confirm.test.tsx (10.409 s)
  ● Confirm › should match snapshot for signature - typed sign - V4 - PermitSingle

    expect(received).toHaveLength(expected)

    Expected length: 2
    Received length: 1
    Received array:  [<p class="mm-box mm-text mm-text--body-md mm-box--color-inherit" style="white-space: pre-wrap;">14,615,016,373,...</p>]

      151 |         await renderWithConfirmContextProvider(<Confirm />, mockStore);
      152 |
    > 153 |       expect(await findAllByText('14,615,016,373,...')).toHaveLength(2);
          |                                                         ^
      154 |       expect(container).toMatchSnapshot();
      155 |     });
      156 |   });

      at toHaveLength (ui/pages/confirmations/confirm/confirm.test.tsx:153:57)

  ● Confirm › should match snapshot for signature - typed sign - V4 - PermitBatch

    expect(received).toHaveLength(expected)

    Expected length: 2
    Received length: 1
    Received array:  [<p class="mm-box mm-text mm-text--body-md mm-box--color-inherit" style="white-space: pre-wrap;">14,615,016,373,...</p>]

      174 |         await renderWithConfirmContextProvider(<Confirm />, mockStore);
      175 |
    > 176 |       expect(await findAllByText('14,615,016,373,...')).toHaveLength(2);
          |                                                         ^
      177 |       expect(container).toMatchSnapshot();
      178 |     });
      179 |   });

      at toHaveLength (ui/pages/confirmations/confirm/confirm.test.tsx:176:57)


Test Suites: 1 failed, 896 passed, 897 total
Tests:       2 failed, 2 todo, 6765 passed, 6769 total

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [7623df0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1687 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1547	1998	1685	116	55
		domContentLoaded	1539	1952	1657	104	50
		load	1547	2012	1687	120	58
		domInteractive	16	159	43	30	14

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)