Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug spending cap label alignment #27338

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Sep 23, 2024

Description

This PR addresses the spending cap label alignment.

Open in GitHub Codespaces

Related issues

Fixes: #27114

Manual testing steps

  1. Go to test-dapp
  2. Use "Sign Permit"
  3. Verify change

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners September 23, 2024 13:31
@OGPoyraz OGPoyraz linked an issue Sep 23, 2024 that may be closed by this pull request
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 23, 2024
Copy link

@sleepytanya
Copy link
Contributor

Looks great!

Before:

Screenshot 2024-09-23 at 11 04 10

After:

Screenshot 2024-09-23 at 11 03 26

@metamaskbot
Copy link
Collaborator

Builds ready [0e55852]
Page Load Metrics (1774 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15942082177514972
domContentLoaded15762034174313565
load15952084177414670
domInteractive18152463617
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 48 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@OGPoyraz OGPoyraz merged commit 24811bb into develop Sep 24, 2024
77 checks passed
@OGPoyraz OGPoyraz deleted the 27114-bug-permit-simulation-spending-cap-label-is-no-longer-top-aligned branch September 24, 2024 07:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Permit Simulation Spending Cap label is no longer top aligned
4 participants