-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert account tracker to typescript #27231
feat: convert account tracker to typescript #27231
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
4d56847
to
c85633a
Compare
c85633a
to
1b07a49
Compare
Quality Gate passedIssues Measures |
Builds ready [1b07a49]
Page Load Metrics (1629 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #27231 +/- ##
===========================================
- Coverage 70.02% 69.99% -0.03%
===========================================
Files 1443 1443
Lines 50164 50172 +8
Branches 14039 14046 +7
===========================================
- Hits 35126 35115 -11
- Misses 15038 15057 +19 ☔ View full report in Codecov by Sentry. |
Builds ready [f47e2cd]
Page Load Metrics (1744 ± 107 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Quality Gate failedFailed conditions |
Builds ready [49410d3]
Page Load Metrics (1812 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Convert AccountTracker (implementation + tests) to TypeScript
Related issues
Fixes: #25928
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist