-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky test Simulation Details displays generic error message
#27156
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27156 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1442 1442
Lines 50100 50100
Branches 14006 14006
========================================
Hits 35049 35049
Misses 15051 15051 ☔ View full report in Codecov by Sentry. |
Builds ready [c4e2948]
Page Load Metrics (1626 ± 81 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Description
This test didn't have the mock correctly implemented, making the request take long, thus sometimes failing the test.
The problem is that in the mock, it sets an
id
of21
however this value is not always the one used in the request.Since we cannot know which id is going to use, we can omit this param and just match the rest of the request body.
Related issues
Fixes: #27157
Manual testing steps
yarn test:e2e:single test/e2e/tests/simulation-details/simulation-details.spec.ts --browser=chrome --leave-running=true
Screenshots/Recordings
See how the request has an id of
0
so it won't be mockedincorrect-mock-id.mp4
Pre-merge author checklist
Pre-merge reviewer checklist