-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make footers and headers sticky in confirmation popups #26853
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
63befff
to
0c7bab7
Compare
|
Builds ready [e0a711c]
Page Load Metrics (1961 ± 140 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26853 +/- ##
===========================================
- Coverage 70.13% 70.13% -0.00%
===========================================
Files 1424 1424
Lines 49571 49577 +6
Branches 13867 13870 +3
===========================================
+ Hits 34765 34768 +3
- Misses 14806 14809 +3 ☔ View full report in Codecov by Sentry. |
Description
New Snaps custom UI pages require UI/UX improvements that also require having sticky headers and footer within the confirmation popup. This PR makes sticky headers and footer, while content in the middle is now scrollable.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist