Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make footers and headers sticky in confirmation popups #26853

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Sep 3, 2024

Description

New Snaps custom UI pages require UI/UX improvements that also require having sticky headers and footer within the confirmation popup. This PR makes sticky headers and footer, while content in the middle is now scrollable.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Do some actions that will trigger the confirmation popup to appear (Snap alert, Snap custom UI dialog, Account Snaps, Add network confirmation, etc.).
  2. Make sure content is visible and headers + footers are sticky/fixed.
  3. Make sure that there are no edge cases with UI glitches, etc.

Screenshots/Recordings

Before

Screenshot 2024-09-03 at 13 05 03
Screenshot 2024-09-03 at 13 05 15
Screenshot 2024-09-03 at 13 05 24
Screenshot 2024-09-03 at 13 05 34

After

Screenshot 2024-09-03 at 12 45 29
Screenshot 2024-09-03 at 12 45 19
Screenshot 2024-09-03 at 12 45 08
Screenshot 2024-09-03 at 12 44 55
Screenshot 2024-09-03 at 12 45 40
Screenshot 2024-09-03 at 12 47 04
Screenshot 2024-09-03 at 12 47 30
Screenshot 2024-09-03 at 12 49 14

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added the team-snaps-platform Snaps Platform team label Sep 3, 2024
@david0xd david0xd self-assigned this Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd force-pushed the dd/sticky-confirmations branch from 63befff to 0c7bab7 Compare September 3, 2024 11:02
@david0xd david0xd marked this pull request as ready for review September 3, 2024 11:08
@david0xd david0xd requested a review from a team as a code owner September 3, 2024 11:08
Copy link

sonarqubecloud bot commented Sep 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [e0a711c]
Page Load Metrics (1961 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint161426041960283136
domContentLoaded158924741926261125
load160826131961291140
domInteractive2211437209
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 219 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (56363e2) to head (e0a711c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...i/pages/confirmations/confirmation/confirmation.js 44.44% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26853      +/-   ##
===========================================
- Coverage    70.13%   70.13%   -0.00%     
===========================================
  Files         1424     1424              
  Lines        49571    49577       +6     
  Branches     13867    13870       +3     
===========================================
+ Hits         34765    34768       +3     
- Misses       14806    14809       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david0xd david0xd merged commit 924b9ce into develop Sep 4, 2024
78 checks passed
@david0xd david0xd deleted the dd/sticky-confirmations branch September 4, 2024 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants