perf: finish getting rid of uses of the Roboto font

[davidmurdoch]

Description

We use two custom fonts in our typography CSS: Euclid Circular B and Roboto.

Roboto is a fallback font, but since both are custom fonts Roboto will never be activated by our default typography. It can be removed.

Roboto is only used in one other place in our CSS, but the selector looks to be not used anymore.

Lastly, Material UI uses Roboto by default for input elements and their labels. This PR updates our use of it to use "Euclid Circular B" and our usual fall back fonts. I don't particularly like the implementation (setting fontFamily as a string constant in JS), but I'm not sure how to do it any better (cc @georgewrmarshall ).

It saves about 0-2ms from the load time (compared to popup-defer-scripts branch), so it's not substantial by any stretch. It does save 1.4 megabytes, about 6%, from the dist zip (compared to popup-defer-scripts branch), which seems worthwhile.

Fixes: #26589

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (d9e989e) to head (9aac394).
Report is 356 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26552   +/-   ##
========================================
  Coverage    70.09%   70.09%           
========================================
  Files         1413     1413           
  Lines        49255    49256    +1     
  Branches     13768    13768           
========================================
+ Hits         34524    34525    +1     
  Misses       14731    14731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [18fe552]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 11 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	186	102	28	14
		domContentLoaded	39	157	71	24	12
		load	46	157	75	24	11
		domInteractive	9	79	30	17	8

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 96 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[davidmurdoch]

I couldn't find any use of this class anywhere in our compiled code.

[georgewrmarshall]

Excellent work thank you for this 💯 LGTM!

• Checked TextField label in storybook to confirm no visual regressions ✅
• Checked no instances of Roboto remain in codebase

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [9aac394]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (73 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	152	100	23	11
		domContentLoaded	42	103	70	18	9
		load	48	103	73	17	8
		domInteractive	10	60	27	14	7

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 96 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.