Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: funding method modal #26426

Merged
merged 39 commits into from
Sep 12, 2024
Merged

feat: funding method modal #26426

merged 39 commits into from
Sep 12, 2024

Conversation

julesat22
Copy link
Contributor

@julesat22 julesat22 commented Aug 14, 2024 •
edited
Loading

Description

Developed the "FundingMethodModal". This CTA displays when a user has no native token balance, and triggering the CTA will now render a modal with 3 options:

  1. "Buy" - Navigates user to Portfolio Buy page
  2. "Receive" - Renders the QR code modal inside the extension
  3. "Transfer" - Will navigate the user to the "Transfers" page with their associated account address to be consumed inside the Portfolio app for CEX transfers

Open in GitHub Codespaces

Related issues

Fixes: --

Manual testing steps

  1. Inside extension, select an account with a 0 token balance
  2. Click the "Get Started" CTA
  3. See that the modal renders and looks good in both light + dark mode
  4. Click on all 3 of the funding method options and ensure the appropriate action is triggered

NOTE

We currently have a feature branch in Portfolio for "Transfer", so this page (/transfer) is not currently in prod. Clicking the "Transfer funds" CTA inside the FundingMethodsModal will give you a page not found error at the moment. This PR will get merge once that code, in Portfolio, is live.

Screenshots/Recordings

Before

Screenshot 2024-08-14 at 12 21 59 PM

After

Screenshot 2024-08-14 at 10 59 15 AM Screenshot 2024-08-14 at 10 59 25 AM Screenshot 2024-08-14 at 10 59 31 AM Screenshot 2024-08-14 at 10 59 58 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@julesat22 julesat22 added DO-NOT-MERGE Pull requests that should not be merged team-portfolio labels Aug 14, 2024
@julesat22 julesat22 requested a review from a team as a code owner August 14, 2024 19:23
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@julesat22 julesat22 self-assigned this Aug 14, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (61c04b3) to head (8406107).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
ui/components/app/assets/asset-list/asset-list.js 53.85% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26426      +/-   ##
===========================================
+ Coverage    70.13%   70.14%   +0.01%     
===========================================
  Files         1425     1427       +2     
  Lines        49669    49709      +40     
  Branches     13895    13904       +9     
===========================================
+ Hits         34833    34867      +34     
- Misses       14836    14842       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2412d15]
Page Load Metrics (80 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81157108189
domContentLoaded115428115
load5010980178
domInteractive115428115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 5.8 KiB (0.08%)
  • common: 587 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [4095418]
Page Load Metrics (89 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint662421315024
domContentLoaded44156843316
load51163893215
domInteractive14492994
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.74 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [16a45b6]
Page Load Metrics (90 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint843651215928
domContentLoaded57281864722
load62281904622
domInteractive199237178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.75 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@julesat22 julesat22 requested a review from a team as a code owner September 6, 2024 15:56
@metamaskbot
Copy link
Collaborator

Builds ready [e7eaf09]
Page Load Metrics (1899 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22931031665678326
domContentLoaded161126581878236113
load162327531899252121
domInteractive179641199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.75 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [317e976]
Page Load Metrics (1894 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28627791746532255
domContentLoaded164727711864250120
load165627811894253122
domInteractive14178443316
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.75 KiB (0.09%)
  • common: 587 Bytes (0.01%)

darkwing
darkwing reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a quick nit but this looks great :)

ui/components/app/assets/asset-list/asset-list.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [615430d]
Page Load Metrics (1802 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22125011660516248
domContentLoaded148724911783261125
load149525031802266128
domInteractive14186403617
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.75 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [8406107]
Page Load Metrics (1682 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14242147168417082
domContentLoaded14172140166717283
load14252145168217282
domInteractive15181413416
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.76 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [9a31f2a]
Page Load Metrics (1907 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22422901841417200
domContentLoaded16022263188519694
load16382280190720096
domInteractive137036136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.76 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [0f146e2]
Page Load Metrics (1685 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28320461605342164
domContentLoaded13932038166516579
load14012046168516479
domInteractive14133462914
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.76 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@julesat22 julesat22 merged commit dfc12b6 into develop Sep 12, 2024
76 of 78 checks passed
@julesat22 julesat22 deleted the MMPD-1296 branch September 12, 2024 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [28c4fa9]
Page Load Metrics (1780 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20520041576564271
domContentLoaded15511935176910048
load1570194117809948
domInteractive187233136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 6.76 KiB (0.09%)
  • common: 587 Bytes (0.01%)

@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jclancy93 jclancy93 jclancy93 approved these changes

@darkwing darkwing darkwing approved these changes

Assignees

@julesat22 julesat22

Labels
design-qa release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-portfolio
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julesat22 @metamaskbot @darkwing @jclancy93 @hesterbruikman