Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permit simulation design #26186

Merged
merged 6 commits into from
Aug 19, 2024
Merged

fix: permit simulation design #26186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd70334
Fix permit simulation design
OGPoyraz Jul 29, 2024
58e5a20
Update snapshots
OGPoyraz Jul 29, 2024
5d6b03d
Snapshot update
OGPoyraz Jul 30, 2024
ed9b488
Another snapshot update
OGPoyraz Jul 30, 2024
e96dbfe
Merge branch 'develop' into 2845-permit-design-review
digiwand Aug 19, 2024
322919d
fix: ConfirmPage snapshot
digiwand Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/components/app/confirm/info/__snapshots__/info.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`ConfirmInfo should match snapshot 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -84,7 +84,7 @@ exports[`ConfirmInfo should match snapshot 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down
2 changes: 1 addition & 1 deletion ui/components/app/confirm/info/row/__snapshots__/expandable-row.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`ConfirmInfoExpandableRow should match snapshot 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down
4 changes: 2 additions & 2 deletions ui/components/app/confirm/info/row/__snapshots__/row.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`ConfirmInfoRow should match snapshot 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -35,7 +35,7 @@ exports[`ConfirmInfoRow should match snapshot when copy is enabled 1`] = `
style="mask-image: url('./images/icons/copy.svg'); cursor: pointer; position: absolute; right: 0px; top: 2px;"
/>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down
2 changes: 1 addition & 1 deletion ui/components/app/confirm/info/row/alert-row/__snapshots__/alert-row.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`AlertRow matches snapshot with no alert 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; background: transparent;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start mm-box--color-text-default"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down
2 changes: 1 addition & 1 deletion ui/components/app/confirm/info/row/row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const ConfirmInfoRow: React.FC<ConfirmInfoRowProps> = ({
display={Display.Flex}
flexDirection={FlexDirection.Row}
justifyContent={JustifyContent.center}
alignItems={AlignItems.center}
alignItems={AlignItems.flexStart}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure that it looks correct for all other cases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note, I will keep this convo in slack.

color={color}
>
<Text variant={TextVariant.bodyMdMedium} color={TextColor.inherit}>
Expand Down
26 changes: 13 additions & 13 deletions ui/pages/confirmations/components/confirm/info/__snapshots__/info.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`Info renders info section for personal sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; background: transparent;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start mm-box--color-text-default"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -52,7 +52,7 @@ exports[`Info renders info section for personal sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; background: transparent;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start mm-box--color-text-default"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -85,7 +85,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -123,7 +123,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -198,7 +198,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand All @@ -214,7 +214,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-left: 0px; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -245,7 +245,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand All @@ -261,7 +261,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand All @@ -285,7 +285,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -358,7 +358,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand All @@ -374,7 +374,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand All @@ -398,7 +398,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -471,7 +471,7 @@ exports[`Info renders info section for typed sign request 1`] = `
style="overflow-wrap: anywhere; min-height: 24px; position: relative; padding-right: 0px;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down
24 changes: 12 additions & 12 deletions ...onents/confirm/info/contract-interaction/__snapshots__/contract-interaction.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -143,7 +143,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -235,7 +235,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative; background: transparent;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start mm-box--color-text-default"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -294,7 +294,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -470,7 +470,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -509,7 +509,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -601,7 +601,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative; background: transparent;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start mm-box--color-text-default"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -660,7 +660,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -833,7 +833,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -872,7 +872,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -964,7 +964,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative; background: transparent;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start mm-box--color-text-default"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down Expand Up @@ -1023,7 +1023,7 @@ exports[`<ContractInteractionInfo /> renders component for contract interaction
style="overflow-wrap: anywhere; min-height: 24px; position: relative;"
>
<div
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-center"
class="mm-box mm-box--display-flex mm-box--flex-direction-row mm-box--justify-content-center mm-box--align-items-flex-start"
>
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
Expand Down
Loading