-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding delete metametrics data to security and privacy tab #24571
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/components/app/clear-metametrics-data/ClearMetaMetricsData.tsx
Outdated
Show resolved
Hide resolved
cd7937d
to
7660d88
Compare
93ae0f6
to
1aa81db
Compare
586ac89
to
cd4aba8
Compare
1941496
to
6a4d150
Compare
cb4f42a
to
429a444
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## delete-metametrics-data-controller #24571 +/- ##
======================================================================
- Coverage 70.19% 70.19% -0.00%
======================================================================
Files 1427 1430 +3
Lines 49745 49829 +84
Branches 13921 13936 +15
======================================================================
+ Hits 34916 34974 +58
- Misses 14829 14855 +26 ☔ View full report in Codecov by Sentry. |
Builds ready [39130bb]
Page Load Metrics (158 ± 192 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
fc6b061
to
e2509b6
Compare
06c5d65
to
8013ee7
Compare
|
Builds ready [8013ee7]
Page Load Metrics (1923 ± 110 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This PR is dependant on #24503
Description
Delete MetaMetrics Data
button.Clear
button in the modal will create a data deletion regulation, update the state, and close the modal, deactivating theDelete MetaMetrics Data
button.Clear
button click opens a new error modal.Scenarios to disable the DeleteMetaMetrics button:
Related issues
Fixes #24406, #24407, https://github.com/MetaMask/MetaMask-planning/issues/2523
Manual testing steps
Perquisite:
Provide the following details in the
.metamaskrc
file:yarn
,yarn dist
) against the code.wygFTooEUUtcckty9kaMc
.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist