Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds the new default settings view to onboarding #24562

Merged
merged 76 commits into from
Oct 10, 2024
Merged

feat: adds the new default settings view to onboarding #24562

merged 76 commits into from
Oct 10, 2024

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented May 16, 2024 •
edited by hesterbruikman
Loading

fixes: MetaMask/MetaMask-planning#2080

--


Description

Introduces the new Default Settings view and Congratulations views depending on the fact if user imported a wallet or created a new one.

User imported a wallet:
Screenshot 2024-06-03 at 16 08 44

User created a new wallet and backed up the seed phrase:
Screenshot 2024-06-03 at 16 11 13

User created a new wallet and didn’t back up the seed phrase:
Screenshot 2024-06-03 at 16 09 37

Inside look on the Default Settings:
Screenshot 2024-06-03 at 16 13 49
Screenshot 2024-06-03 at 16 14 00

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live changed the title [MMI] adds default settings view to onboarding feat: adds the new default settings view to onboarding May 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a81133f]
Page Load Metrics (1002 ± 551 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6114092199
domContentLoaded9301463
load57256410021147551
domInteractive9301463
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.01 KiB (0.06%)
  • common: 647 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [cf34cc7]
Page Load Metrics (803 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60193953115
domContentLoaded96416136
load4828258031122539
domInteractive96416136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.01 KiB (0.06%)
  • common: 647 Bytes (0.01%)

@zone-live zone-live marked this pull request as ready for review June 4, 2024 11:07
@zone-live zone-live requested a review from a team as a code owner June 4, 2024 11:07
@darkwing darkwing force-pushed the MMI-5007-add-advanced-configuration-to-onboarding branch from 5150eeb to 5ea6c3e Compare October 8, 2024 13:56
@darkwing darkwing force-pushed the MMI-5007-add-advanced-configuration-to-onboarding branch from 5ea6c3e to 2e3bdcd Compare October 8, 2024 15:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [2e3bdcd]
Page Load Metrics (1904 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38726201761430206
domContentLoaded164826101887226108
load168926321904226109
domInteractive21104462411
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.99 KiB (0.06%)
  • common: 347 Bytes (0.00%)

jonybur
jonybur approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@jonybur jonybur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments but they are non-blocking

test/e2e/tests/network/multi-rpc.spec.ts Show resolved Hide resolved
test/integration/onboarding/wallet-created.test.tsx
expect(onboardingPinExtensionMetricsEvent?.[0]).toBe(
'trackMetaMetricsEvent',
);
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

await waitFor(() => {
  const [requestType] = mockedBackgroundConnection.submitRequestToBackground.mock.calls.find(
    ([callType]) => callType === 'trackMetaMetricsEvent'
  ) || [];

  expect(requestType).toBe('trackMetaMetricsEvent');
});

Maybe this would be a bit cleaner, what do you think?

ui/pages/onboarding-flow/privacy-settings/privacy-settings.js
setShowDetail(false);
setTimeout(() => {
setHiddenClass(true);
}, 500);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it'd be good to move this 500 value to the top and share it between the handleItemSelected and the handleBack

ui/pages/onboarding-flow/privacy-settings/privacy-settings.js
/>
</>
) : null}
{selectedItem && selectedItem.id === 2 ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it'd be good to split this return clause into smaller components for readability and maintanability.

@jonybur
Copy link
Contributor

jonybur commented Oct 9, 2024 •
edited
Loading

bug.mp4

Found this odd behaviour, please check out. "You're now using Linea Mainnet 2" toast is shown and automatically closed

@darkwing darkwing added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 61adc78 Oct 10, 2024
78 checks passed
@darkwing darkwing deleted the MMI-5007-add-advanced-configuration-to-onboarding branch October 10, 2024 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 10, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seaona seaona seaona left review comments

@darkwing darkwing darkwing approved these changes

@jonybur jonybur jonybur approved these changes

@andreahaku andreahaku andreahaku left review comments

Assignees

@vinnyhoward vinnyhoward

Labels
design-qa needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@zone-live @metamaskbot @yanrong-chen @hesterbruikman @jonybur @darkwing @andreahaku @seaona @gauthierpetetin @vinnyhoward